[MD] some tweaks to download shelf

chrome/browser/ui/views/toolbar/app_menu_button.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/app_menu_button.h"
 
 #include "base/location.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
@@ skipping 172 matching lines @@
   UpdateThemedBorder();
 
   const int inset = LabelButton::kFocusRectInset;
   SetFocusPainter(views::Painter::CreateDashedFocusPainterWithInsets(
       gfx::Insets(inset, inset, inset, inset + margin)));
   InvalidateLayout();
 }
 
 gfx::Point AppMenuButton::GetInkDropCenter() const {
   // ToolbarView extends the bounds of the app button to the right in maximized
-  // mode. So instead of using the center point of local bounds, we use the
-  // center point (adjusted for RTL layouts) of the preferred size, which
-  // doesn't change in maximized mode.
-  const int visible_width = GetPreferredSize().width();
-  return gfx::Point(
-      (GetMirroredXWithWidthInView(0, visible_width) + visible_width) / 2,
-      height() / 2);
+  // mode.
+  return image()->bounds().CenterPoint();

[varkha, 2016/03/03 04:39:10]

This seems wrong. I am running with --lang=he in command line and a maximized
browser displays hover / activated ripple in a wrong spot.
Interestingly enough the positioning is wrong before this change but it was
closer to the visible center of the icon meaning there was a slight regression
even before that.

 }
 
 const char* AppMenuButton::GetClassName() const {
   return "AppMenuButton";
 }
 
 scoped_ptr<views::LabelButtonBorder> AppMenuButton::CreateDefaultBorder()
     const {
   scoped_ptr<views::LabelButtonBorder> border =
       MenuButton::CreateDefaultBorder();
@@ skipping 67 matching lines @@
   views::MenuButton::OnPaint(canvas);
   if (ui::MaterialDesignController::IsModeMaterial())
     return;
   // Use GetPreferredSize() to center the icon inside the visible bounds rather
   // than the whole size() (which may refer to hit test region extended to the
   // end of the toolbar in maximized mode).
   icon_painter_->Paint(canvas, GetThemeProvider(),
                        gfx::Rect(GetPreferredSize()),
                        AppMenuIconPainter::BEZEL_NONE);
 }