[MD] some tweaks to download shelf

[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
Committed: https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f
Cr-Commit-Position: refs/heads/master@{#379731}

[Evan Stade, 2016-03-03 04:12:35]

Description was changed from

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
 - ink drop is spec'd to 32x32 for "small" size
- fix some layout issues affecting item internals
- simplify AppMenuButton::GetInkDropCenter()
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

to

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size
- fix some layout issues affecting item internals
- simplify AppMenuButton::GetInkDropCenter()
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

[Evan Stade, 2016-03-03 04:12:53]

Description was changed from

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size
- fix some layout issues affecting item internals
- simplify AppMenuButton::GetInkDropCenter()
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

to

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- simplify AppMenuButton::GetInkDropCenter()
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

[Evan Stade, 2016-03-03 04:14:01]

estade@chromium.org changed reviewers:
+ sky@chromium.org, varkha@chromium.org

[Evan Stade, 2016-03-03 04:14:01]

varkha: app_menu_button.cc
sky: all

thanks!

[Evan Stade, 2016-03-03 04:15:36]

Actually I'm going to split app_menu_button.cc changes into a different CL.

[Evan Stade, 2016-03-03 04:17:30]

Description was changed from

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- simplify AppMenuButton::GetInkDropCenter()
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

to

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

[Evan Stade, 2016-03-03 04:27:57]

estade@chromium.org changed reviewers:
- varkha@chromium.org

[varkha, 2016-03-03 04:39:10]

varkha@chromium.org changed reviewers:
+ varkha@chromium.org

[varkha, 2016-03-03 04:39:11]

https://codereview.chromium.org/1750403005/diff/1/chrome/browser/ui/views/too...
File chrome/browser/ui/views/toolbar/app_menu_button.cc (right):

https://codereview.chromium.org/1750403005/diff/1/chrome/browser/ui/views/too...
chrome/browser/ui/views/toolbar/app_menu_button.cc:194: return
image()->bounds().CenterPoint();
This seems wrong. I am running with --lang=he in command line and a maximized
browser displays hover / activated ripple in a wrong spot.
Interestingly enough the positioning is wrong before this change but it was
closer to the visible center of the icon meaning there was a slight regression
even before that.

[Evan Stade, 2016-03-03 04:40:24]

On 2016/03/03 04:39:11, varkha wrote:
>
https://codereview.chromium.org/1750403005/diff/1/chrome/browser/ui/views/too...
> File chrome/browser/ui/views/toolbar/app_menu_button.cc (right):
> 
>
https://codereview.chromium.org/1750403005/diff/1/chrome/browser/ui/views/too...
> chrome/browser/ui/views/toolbar/app_menu_button.cc:194: return
> image()->bounds().CenterPoint();
> This seems wrong. I am running with --lang=he in command line and a maximized
> browser displays hover / activated ripple in a wrong spot.
> Interestingly enough the positioning is wrong before this change but it was
> closer to the visible center of the icon meaning there was a slight regression
> even before that.

that change was moved here (intentionally not yet sent for review):
https://codereview.chromium.org/1761443003/

[Evan Stade, 2016-03-03 22:17:58]

estade@chromium.org changed reviewers:
- varkha@chromium.org

[Evan Stade, 2016-03-07 18:43:16]

ping sky

[sky, 2016-03-07 21:18:24]

LGTM

https://codereview.chromium.org/1750403005/diff/20001/ui/gfx/geometry/insets.h
File ui/gfx/geometry/insets.h (right):

https://codereview.chromium.org/1750403005/diff/20001/ui/gfx/geometry/insets....
ui/gfx/geometry/insets.h:18: Insets(int all);
explicit

[Evan Stade, 2016-03-07 23:08:10]

https://codereview.chromium.org/1750403005/diff/20001/ui/gfx/geometry/insets.h
File ui/gfx/geometry/insets.h (right):

https://codereview.chromium.org/1750403005/diff/20001/ui/gfx/geometry/insets....
ui/gfx/geometry/insets.h:18: Insets(int all);
On 2016/03/07 21:18:24, sky wrote:
> explicit

Done.

[Evan Stade, 2016-03-07 23:08:14]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-03-07 23:08:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1750403005/#ps40001
(title: "explicit")

[commit-bot: I haz the power, 2016-03-07 23:08:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750403005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750403005/40001

[commit-bot: I haz the power, 2016-03-07 23:38:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 23:38:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Evan Stade, 2016-03-08 00:58:08]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-03-08 00:58:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750403005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750403005/40001

[commit-bot: I haz the power, 2016-03-08 04:14:11]

Description was changed from

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

to

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

[commit-bot: I haz the power, 2016-03-08 04:14:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-08 04:15:37]

Description was changed from

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582
==========

to

==========
[MD] some tweaks to download shelf

- add ripple to dropdown button
  - ink drop is spec'd to 32x32 for "small" size while the touch target is 36x36
- fix some layout issues affecting item internals
- add some convenience ctors to gfx::Insets (a scan of the code indicates
  there are many places these could be used)

BUG=591582

Committed: https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f
Cr-Commit-Position: refs/heads/master@{#379731}
==========

[commit-bot: I haz the power, 2016-03-08 04:15:38]

Patchset 3 (id:??) landed as
https://crrev.com/93bfca9c89bf3f9232206b07ca312665c825810f
Cr-Commit-Position: refs/heads/master@{#379731}