Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1750323002: Keep XHR progress throttle interval an implementation detail. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep XHR progress throttle interval an implementation detail. R= BUG= Committed: https://crrev.com/739ae91dc5e577cf27a78ae5723208c61e814a7a Cr-Commit-Position: refs/heads/master@{#378487}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp View 4 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 9 months ago (2016-03-01 14:11:28 UTC) #2
yhirano
lgtm https://codereview.chromium.org/1750323002/diff/1/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp (right): https://codereview.chromium.org/1750323002/diff/1/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp#newcode39 third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp:39: static const double kMinimumProgressEventDispatchingIntervalInSeconds = .05; // 50 ...
4 years, 9 months ago (2016-03-01 17:43:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750323002/1
4 years, 9 months ago (2016-03-01 18:18:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 18:34:08 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 18:35:29 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/739ae91dc5e577cf27a78ae5723208c61e814a7a
Cr-Commit-Position: refs/heads/master@{#378487}

Powered by Google App Engine
This is Rietveld 408576698