Keep XHR progress throttle interval an implementation detail.

third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.cpp

 /*
  * Copyright (C) 2010 Julien Chaffraix <jchaffraix@webkit.org>  All right reserved.
  * Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 18 matching lines @@
 #include "core/EventTypeNames.h"
 #include "core/events/ProgressEvent.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/inspector/InspectorTraceEvents.h"
 #include "core/xmlhttprequest/XMLHttpRequest.h"
 #include "wtf/Assertions.h"
 #include "wtf/text/AtomicString.h"
 
 namespace blink {
 
+static const double kMinimumProgressEventDispatchingIntervalInSeconds = .05; // 50 ms per specification.

[yhirano, 2016/03/01 17:43:54]

I generally prefer an unnamed namespace to static.

+
 XMLHttpRequestProgressEventThrottle::DeferredEvent::DeferredEvent()
 {
     clear();
 }
 
 void XMLHttpRequestProgressEventThrottle::DeferredEvent::set(bool lengthComputable, unsigned long long loaded, unsigned long long total)
 {
     m_isSet = true;
 
     m_lengthComputable = lengthComputable;
@@ skipping 12 matching lines @@
 
 PassRefPtrWillBeRawPtr<Event> XMLHttpRequestProgressEventThrottle::DeferredEvent::take()
 {
     ASSERT(m_isSet);
 
     RefPtrWillBeRawPtr<Event> event = ProgressEvent::create(EventTypeNames::progress, m_lengthComputable, m_loaded, m_total);
     clear();
     return event.release();
 }
 
-const double XMLHttpRequestProgressEventThrottle::minimumProgressEventDispatchingIntervalInSeconds = .05; // 50 ms per specification.
-
 XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle(XMLHttpRequest* target)
     : m_target(target)
     , m_hasDispatchedProgressProgressEvent(false)
 {
     ASSERT(target);
 }
 
 XMLHttpRequestProgressEventThrottle::~XMLHttpRequestProgressEventThrottle()
 {
 }
 
 void XMLHttpRequestProgressEventThrottle::dispatchProgressEvent(const AtomicString& type, bool lengthComputable, unsigned long long loaded, unsigned long long total)
 {
     // Given that ResourceDispatcher doesn't deliver an event when suspended,
     // we don't have to worry about event dispatching while suspended.
     if (type != EventTypeNames::progress) {
         m_target->dispatchEvent(ProgressEvent::create(type, lengthComputable, loaded, total));
         return;
     }
 
     if (isActive()) {
         m_deferred.set(lengthComputable, loaded, total);
     } else {
         dispatchProgressProgressEvent(ProgressEvent::create(EventTypeNames::progress, lengthComputable, loaded, total));
-        startOneShot(minimumProgressEventDispatchingIntervalInSeconds, BLINK_FROM_HERE);
+        startOneShot(kMinimumProgressEventDispatchingIntervalInSeconds, BLINK_FROM_HERE);
     }
 }
 
 void XMLHttpRequestProgressEventThrottle::dispatchReadyStateChangeEvent(PassRefPtrWillBeRawPtr<Event> event, DeferredEventAction action)
 {
     XMLHttpRequest::State state = m_target->readyState();
     // Given that ResourceDispatcher doesn't deliver an event when suspended,
     // we don't have to worry about event dispatching while suspended.
     if (action == Flush) {
         if (m_deferred.isSet())
@@ skipping 35 matching lines @@
 {
     if (!m_deferred.isSet()) {
         // No "progress" event was queued since the previous dispatch, we can
         // safely stop the timer.
         return;
     }
 
     dispatchProgressProgressEvent(m_deferred.take());
 
     // Watch if another "progress" ProgressEvent arrives in the next 50ms.
-    startOneShot(minimumProgressEventDispatchingIntervalInSeconds, BLINK_FROM_HERE);
+    startOneShot(kMinimumProgressEventDispatchingIntervalInSeconds, BLINK_FROM_HERE);
 }
 
 void XMLHttpRequestProgressEventThrottle::suspend()
 {
     stop();
 }
 
 void XMLHttpRequestProgressEventThrottle::resume()
 {
     if (!m_deferred.isSet())
         return;
 
     // Do not dispatch events inline here, since ExecutionContext is iterating
     // over the list of active DOM objects to resume them, and any activated JS
     // event-handler could insert new active DOM objects to the list.
     startOneShot(0, BLINK_FROM_HERE);
 }
 
 DEFINE_TRACE(XMLHttpRequestProgressEventThrottle)
 {
     visitor->trace(m_target);
 }
 
 } // namespace blink