Issue 1750303003: Remove unnecessary ReadPacket method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1750303003: Remove unnecessary ReadPacket method. (Closed)

Created:
4 years, 9 months ago by danzh1

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade

Base URL:
https://chromium.googlesource.com/chromium/src.git@115244730

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove unnecessary ReadPacket method. Merge internal change: 115339832 R=rch@chromium.org BUG=

Patch Set 2 : rebase on to 115261503 #

Patch Set 3 : remove all change brought from 115261503 #

Patch Set 4 : revert to Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -16 lines)			Patch
	M	net/tools/quic/quic_client.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	net/tools/quic/quic_client.cc	View		2 chunks	+4 lines, -11 lines	0 comments	Download

Depends on Patchset:

Issue 1753453003 Patch 1

Dependent Patchsets:

Issue 1755663002 Patch 60001

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750303003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750303003/60001

4 years, 9 months ago (2016-03-04 14:56:46 UTC) #4

commit-bot: I haz the power

4 years, 9 months ago (2016-03-04 15:43:09 UTC) #6

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages