Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2549)

Unified Diff: net/tools/quic/quic_client.cc

Issue 1750303003: Remove unnecessary ReadPacket method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115244730
Patch Set: revert to Patch Set 1 Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_client.cc
diff --git a/net/tools/quic/quic_client.cc b/net/tools/quic/quic_client.cc
index b8472d041ed5ba812d65a5a2b0e0a1f0ad20fcf7..6a4c3127c7c7ddb3de808dbe4f9b0c9c510e9f10 100644
--- a/net/tools/quic/quic_client.cc
+++ b/net/tools/quic/quic_client.cc
@@ -498,16 +498,6 @@ QuicPacketReader* QuicClient::CreateQuicPacketReader() {
return nullptr;
}
-int QuicClient::ReadPacket(char* buffer,
- int buffer_len,
- IPEndPoint* server_address,
- IPAddress* client_ip) {
- return QuicSocketUtils::ReadPacket(
- GetLatestFD(), buffer, buffer_len,
- overflow_supported_ ? &packets_dropped_ : nullptr, client_ip,
- server_address);
-}
-
bool QuicClient::ReadAndProcessPacket() {
// Allocate some extra space so we can send an error if the server goes over
// the limit.
@@ -516,7 +506,10 @@ bool QuicClient::ReadAndProcessPacket() {
IPEndPoint server_address;
IPAddress client_ip;
- int bytes_read = ReadPacket(buf, arraysize(buf), &server_address, &client_ip);
+ int bytes_read = QuicSocketUtils::ReadPacket(
+ GetLatestFD(), buf, arraysize(buf),
+ overflow_supported_ ? &packets_dropped_ : nullptr, &client_ip,
+ &server_address);
if (bytes_read < 0) {
return false;
« no previous file with comments | « net/tools/quic/quic_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698