Minor fixes to tools/gn.

Minor fixes to tools/gn.

Fix incorrect array indexing in EnsureValidSourcesSubstitutions when
reporting an invalid substitution usage (the code was using the index
in another array to index in kSubstitutionNames).

Remove declaration of CopyTargetGenerator::FillDestDir as the method
is not implemented.

Fix some typos in comments and in the name of IsValidToolSubstitution
(was spelled out IsValidToolSubst*u*t*i*tion).

BUG=297668
Committed: https://crrev.com/d1d65269209951e2e784682b47087d04e93a44bf
Cr-Commit-Position: refs/heads/master@{#379256}

[sdefresne, 2016-03-01 19:06:48]

sdefresne@chromium.org changed reviewers:
+ brettw@chromium.org

[sdefresne, 2016-03-01 19:06:49]

Please take a look. This fix some minor issues (and some potential Undefined
Behaviour) that I found while implementing the support of bundle_data &
create_bundle targets.

[tfarina, 2016-03-01 19:16:50]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2016-03-01 19:16:50]

Looks like there are still some calls to IsValidToolSubstutition to be fixed.

Looks fine and I don't see anything wrong. Informal, non-owner LGTM.

Thanks for fixing all the spelling/typos :)

We should pass a spell-checker in tools/gn someday!

[sdefresne, 2016-03-01 19:20:54]

On 2016/03/01 at 19:16:50, tfarina wrote:
> Looks like there are still some calls to IsValidToolSubstutition to be fixed.
> 
> Looks fine and I don't see anything wrong. Informal, non-owner LGTM.
> 
> Thanks for fixing all the spelling/typos :)
> 
> We should pass a spell-checker in tools/gn someday!

Ack, I extracted the changes from another CL and apparently I missed one
occurrence. Should be fixed in patchset #2.

[sdefresne, 2016-03-03 17:57:25]

brettw: ping?

[brettw, 2016-03-03 19:09:00]

LGTM !

https://codereview.chromium.org/1750283003/diff/20001/tools/gn/substitution_t...
File tools/gn/substitution_type.cc (left):

https://codereview.chromium.org/1750283003/diff/20001/tools/gn/substitution_t...
tools/gn/substitution_type.cc:130: bool IsValidToolSubstutition(SubstitutionType
type) {
Wow, this is some awesome copy-and-paste thing I had going.

[sdefresne, 2016-03-04 08:53:57]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-03-04 08:53:57]

The patchset sent to the CQ was uploaded after l-g-t-m from tfarina@chromium.org
Link to the patchset: https://codereview.chromium.org/1750283003/#ps20001
(title: "Fix last reference to IsValidToolSubstutition.")

[commit-bot: I haz the power, 2016-03-04 08:54:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750283003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750283003/20001

[commit-bot: I haz the power, 2016-03-04 09:35:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-04 09:37:15]

Description was changed from

==========
Minor fixes to tools/gn.

Fix incorrect array indexing in EnsureValidSourcesSubstitutions when
reporting an invalid substitution usage (the code was using the index
in another array to index in kSubstitutionNames).

Remove declaration of CopyTargetGenerator::FillDestDir as the method
is not implemented.

Fix some typos in comments and in the name of IsValidToolSubstitution
(was spelled out IsValidToolSubst*u*t*i*tion).

BUG=297668
==========

to

==========
Minor fixes to tools/gn.

Fix incorrect array indexing in EnsureValidSourcesSubstitutions when
reporting an invalid substitution usage (the code was using the index
in another array to index in kSubstitutionNames).

Remove declaration of CopyTargetGenerator::FillDestDir as the method
is not implemented.

Fix some typos in comments and in the name of IsValidToolSubstitution
(was spelled out IsValidToolSubst*u*t*i*tion).

BUG=297668

Committed: https://crrev.com/d1d65269209951e2e784682b47087d04e93a44bf
Cr-Commit-Position: refs/heads/master@{#379256}
==========

[commit-bot: I haz the power, 2016-03-04 09:37:16]

Patchset 2 (id:??) landed as
https://crrev.com/d1d65269209951e2e784682b47087d04e93a44bf
Cr-Commit-Position: refs/heads/master@{#379256}