Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1750263002: Devtools: Do not greedily collapse URLs (Closed)

Created:
4 years, 9 months ago by samli
Modified:
4 years, 9 months ago
Reviewers:
kozy, dgozman, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devtools: Do not greedily collapse URLs A longstanding bug resulted in a property value containing multiple URLs was being matched as a single URL and collapsed. When re-expanding this, the original text was then not restored correctly. This then resulted in the incorrect style being applied upon any edit. BUG=590172 Committed: https://crrev.com/5ac5f0c65ec60fa465e378b295d8aca067986234 Cr-Commit-Position: refs/heads/master@{#378982}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
A + third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html View 1 2 4 chunks +4 lines, -8 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
samli
4 years, 9 months ago (2016-03-01 06:11:57 UTC) #2
dgozman
Over to Andrey.
4 years, 9 months ago (2016-03-01 06:17:27 UTC) #4
kozy
Can we add a test?
4 years, 9 months ago (2016-03-01 22:05:40 UTC) #6
samli
On 2016/03/01 at 22:05:40, kozyatinskiy wrote: > Can we add a test? Done.
4 years, 9 months ago (2016-03-03 03:17:30 UTC) #7
lushnikov
lgtm % nit https://codereview.chromium.org/1750263002/diff/20001/third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html File third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html (right): https://codereview.chromium.org/1750263002/diff/20001/third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html#newcode52 third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html:52: Tests that multiple URLs which are ...
4 years, 9 months ago (2016-03-03 05:05:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750263002/40001
4 years, 9 months ago (2016-03-03 05:10:58 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-03 08:12:31 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 08:14:01 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ac5f0c65ec60fa465e378b295d8aca067986234
Cr-Commit-Position: refs/heads/master@{#378982}

Powered by Google App Engine
This is Rietveld 408576698