third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html - Issue 1750263002: Devtools: Do not greedily collapse URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html

Issue 1750263002: Devtools: Do not greedily collapse URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html

diff --git a/third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html b/third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html

similarity index 70%

copy from third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html

copy to third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html

index b0647df0c60769b38c8a2ce17bc755dc70d92d7e..a99155540897ffe77cbba1aa21046e1ed3ee3ef5 100644

--- a/third_party/WebKit/LayoutTests/inspector/elements/styles/url-color-swatch.html

+++ b/third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing.html

@@ -2,7 +2,7 @@

<head>

<style>

#inspected {

- background-image: url("red green blue.jpg");

+ background: -webkit-image-set(url("chrome-search://theme/IDR_THEME_NTP_BACKGROUND?pfncmbjabnpldlfbnmhnhblapoibfbei") 1x, url("chrome-search://theme/IDR_THEME_NTP_BACKGROUND@2x?pfncmbjabnpldlfbnmhnhblapoibfbei") 2x);

color: red;

}

</style>

@@ -16,8 +16,7 @@ function test()

function step1()

{

- dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("background-image"));

- dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("color"));

+ dumpDOM(InspectorTest.getMatchedStylePropertyTreeItem("background"));

InspectorTest.completeTest();

}

@@ -36,10 +35,7 @@ function test()

var node = childNodes[i];

switch (node.nodeType) {

case Node.ELEMENT_NODE:

- if (node.getAttribute("is") === "color-swatch")

- result.push("[] " + node.textContent);

- else

- dumpNode(node, result);

+ dumpNode(node, result);

break;

case Node.TEXT_NODE:

result.push(node.nodeValue);

@@ -53,7 +49,7 @@ function test()

</head>

<p>

-Tests that url(...) with space-delimited color names as filename segments do not contain color swatches. Bug <a href="http://bugs.webkit.org/show_bug.cgi?id=106770">106770</a>.

+Tests that multiple URLs which are long are not squashed into a single URL. Bug <a href="http://crbug.com/590172">590172</a>.

</p>

</body>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/elements/styles/url-multiple-collapsing-expected.txt » ('j') | no next file with comments »