Separate 'isQualified' flags as List<bool>.

Separate 'isQualified' flags as List<bool>.

It turned out that for used names we don't need any flags because we
want to store only qualified unresolved (potential) class member
usages. So, no flags for used names at all, at least for now.


R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/7d0fbd1b117b1deb7549151c69205dcfd3ff0019

[Paul Berry, 2016-03-01 17:06:19]

Assuming I'm correct about the additional places in index_unit.dart that need to
use `isQualified`, please add tests that would have caught these bugs.

With that, lgtm.

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:627: @Id(7)
Please don't renumber the Ids when adding a new field.  Just add it with the
next available Id, in this case 11.

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:296: {bool isQualified: false}) {
Consider making this a required parameter so that we don't accidentally forget
about cases that might be qualified (see below).

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:343:
recordRelation(name.staticElement, kind, name);
I think we need to pass a value for "isQualified" here, since supertypes can be
qualified (e.g. `class C extends prefix.Base {}`)

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:449: recordRelation(element,
IndexRelationKind.IS_REFERENCED_BY, name);
This could also be qualified, e.g.:

foo.dart:
    class A {}

test.dart:
    import 'foo.dart' as prefix;
    main() {
      prefix.A(); // invalid code, but still a reference
    }

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/tool/summary/g...
File pkg/analyzer/tool/summary/generate.dart (right):

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/tool/summary/g...
pkg/analyzer/tool/summary/generate.dart:361: typeStr = 'ubyte';
It would be nice to have a comment here explaining why we make an exception for
bools.  E.g. something like "Flatbuffers don't natively support a packed list of
bools, so we treat it as a list of unsigned bytes, which is a compatible data
structure."

[scheglov, 2016-03-01 19:05:34]

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/idl.dart (right):

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/idl.dart:627: @Id(7)
On 2016/03/01 17:06:19, Paul Berry wrote:
> Please don't renumber the Ids when adding a new field.  Just add it with the
> next available Id, in this case 11.

Done.

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/index_unit.dart (right):

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:296: {bool isQualified: false}) {
On 2016/03/01 17:06:19, Paul Berry wrote:
> Consider making this a required parameter so that we don't accidentally forget
> about cases that might be qualified (see below).

Done.

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:343:
recordRelation(name.staticElement, kind, name);
On 2016/03/01 17:06:19, Paul Berry wrote:
> I think we need to pass a value for "isQualified" here, since supertypes can
be
> qualified (e.g. `class C extends prefix.Base {}`)

Done.

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/index_unit.dart:449: recordRelation(element,
IndexRelationKind.IS_REFERENCED_BY, name);
On 2016/03/01 17:06:19, Paul Berry wrote:
> This could also be qualified, e.g.:
> 
> foo.dart:
>     class A {}
> 
> test.dart:
>     import 'foo.dart' as prefix;
>     main() {
>       prefix.A(); // invalid code, but still a reference
>     }

Done.

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/tool/summary/g...
File pkg/analyzer/tool/summary/generate.dart (right):

https://codereview.chromium.org/1750163003/diff/1/pkg/analyzer/tool/summary/g...
pkg/analyzer/tool/summary/generate.dart:361: typeStr = 'ubyte';
On 2016/03/01 17:06:19, Paul Berry wrote:
> It would be nice to have a comment here explaining why we make an exception
for
> bools.  E.g. something like "Flatbuffers don't natively support a packed list
of
> bools, so we treat it as a list of unsigned bytes, which is a compatible data
> structure."

Done.

[scheglov, 2016-03-01 19:06:46]

Description was changed from

==========
Separate 'isQualified' flags as List<bool>.

It turned out that for used names we don't need any flags because we
want to store only qualified unresolved (potential) class member
usages. So, no flags for used names at all, at least for now.


R=paulberry@google.com
BUG=
==========

to

==========
Separate 'isQualified' flags as List<bool>.

It turned out that for used names we don't need any flags because we
want to store only qualified unresolved (potential) class member
usages. So, no flags for used names at all, at least for now.


R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/7d0fbd1b117b1deb7549151c69205dcfd3ff0019
==========

[scheglov, 2016-03-01 19:06:48]

Committed patchset #1 (id:1) manually as
7d0fbd1b117b1deb7549151c69205dcfd3ff0019 (presubmit successful).