Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: pkg/analyzer/lib/src/summary/idl.dart

Issue 1750163003: Separate 'isQualified' flags as List<bool>. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/summary/idl.dart
diff --git a/pkg/analyzer/lib/src/summary/idl.dart b/pkg/analyzer/lib/src/summary/idl.dart
index 46e9172a1eff1a4deb887d6387fe63f098a2f4de..b078ad88c5402206e7a1d6598c2e2f9af2a4a176 100644
--- a/pkg/analyzer/lib/src/summary/idl.dart
+++ b/pkg/analyzer/lib/src/summary/idl.dart
@@ -196,25 +196,11 @@ enum IndexRelationKind {
IS_INVOKED_BY,
/**
- * Left: method, property accessor, function, variable.
- * Is invoked with a qualifier at.
- * Right: location.
- */
- IS_INVOKED_QUALIFIED_BY,
-
- /**
* Left: any element.
* Is referenced (and not invoked, read/written) at.
* Right: location.
*/
- IS_REFERENCED_BY,
-
- /**
- * Left: any element.
- * Is referenced (and not invoked, read/written) with a qualifier at.
- * Right: location.
- */
- IS_REFERENCED_QUALIFIED_BY
+ IS_REFERENCED_BY
}
/**
@@ -638,14 +624,14 @@ abstract class UnitIndex extends base.SummaryClass {
/**
* Each item of this list is the kind of an element defined in this unit.
*/
- @Id(6)
+ @Id(7)
Paul Berry 2016/03/01 17:06:19 Please don't renumber the Ids when adding a new fi
scheglov 2016/03/01 19:05:34 Done.
List<IndexNameKind> get definedNameKinds;
/**
* Each item of this list is the name offset of an element defined in this
* unit relative to the beginning of the file.
*/
- @Id(7)
+ @Id(8)
List<int> get definedNameOffsets;
/**
@@ -654,7 +640,7 @@ abstract class UnitIndex extends base.SummaryClass {
* ascending order, so that the client can quickly find name definitions in
* this [UnitIndex].
*/
- @Id(5)
+ @Id(6)
List<int> get definedNames;
/**
@@ -665,22 +651,29 @@ abstract class UnitIndex extends base.SummaryClass {
int get unit;
/**
+ * Each item of this list is the `true` if the corresponding element usage
+ * is qualified with some prefix.
+ */
+ @Id(5)
+ List<bool> get usedElementIsQualifiedFlags;
+
+ /**
* Each item of this list is the kind of the element usage.
*/
- @Id(4)
+ @Id(2)
List<IndexRelationKind> get usedElementKinds;
/**
* Each item of this list is the length of the element usage.
*/
- @Id(1)
+ @Id(4)
List<int> get usedElementLengths;
/**
* Each item of this list is the offset of the element usage relative to the
* beginning of the file.
*/
- @Id(2)
+ @Id(3)
List<int> get usedElementOffsets;
/**
@@ -688,20 +681,20 @@ abstract class UnitIndex extends base.SummaryClass {
* [PackageIndex.elementOffsets]. The list is sorted in ascending order, so
* that the client can quickly find element references in this [UnitIndex].
*/
- @Id(3)
+ @Id(1)
List<int> get usedElements;
/**
* Each item of this list is the kind of the name usage.
*/
- @Id(10)
+ @Id(11)
List<IndexRelationKind> get usedNameKinds;
/**
* Each item of this list is the offset of the name usage relative to the
* beginning of the file.
*/
- @Id(9)
+ @Id(10)
List<int> get usedNameOffsets;
/**
@@ -709,7 +702,7 @@ abstract class UnitIndex extends base.SummaryClass {
* used name. The list is sorted in ascending order, so that the client can
* quickly find name uses in this [UnitIndex].
*/
- @Id(8)
+ @Id(9)
List<int> get usedNames;
}

Powered by Google App Engine
This is Rietveld 408576698