Move more messages.

Move more messages.

Migrates some of the 'undefined' messages to the shared file.

R=brianwilkerson@google.com, johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/dd326beee1b1b4d1437bedb1aea2d6af2378de6f

[floitsch, 2016-03-06 20:22:48]

Description was changed from

==========
Move more messages. WIP.

BUG=
==========

to

==========
Move more messages.

Migrates some of the 'undefined' messages to the shared file.
==========

[floitsch, 2016-03-07 09:36:12]

floitsch@google.com changed reviewers:
+ brianwilkerson@google.com, johnniwinther@google.com

[Johnni Winther, 2016-03-07 10:25:18]

dart2js changes LGTM

https://chromiumcodereview.appspot.com/1750143005/diff/20001/tests/compiler/d...
File tests/compiler/dart2js/analyze_test_test.dart (left):

https://chromiumcodereview.appspot.com/1750143005/diff/20001/tests/compiler/d...
tests/compiler/dart2js/analyze_test_test.dart:33: ],
Why did this change?

[floitsch, 2016-03-07 10:26:24]

https://chromiumcodereview.appspot.com/1750143005/diff/20001/tests/compiler/d...
File tests/compiler/dart2js/analyze_test_test.dart (left):

https://chromiumcodereview.appspot.com/1750143005/diff/20001/tests/compiler/d...
tests/compiler/dart2js/analyze_test_test.dart:33: ],
On 2016/03/07 10:25:18, Johnni Winther wrote:
> Why did this change?

When I ran `tools/test.py dart2js` it complained. I'm not sure, why this wasn't
an issue before.

[floitsch, 2016-03-07 13:52:06]

https://chromiumcodereview.appspot.com/1750143005/diff/20001/tests/compiler/d...
File tests/compiler/dart2js/analyze_test_test.dart (left):

https://chromiumcodereview.appspot.com/1750143005/diff/20001/tests/compiler/d...
tests/compiler/dart2js/analyze_test_test.dart:33: ],
On 2016/03/07 10:26:24, floitsch wrote:
> On 2016/03/07 10:25:18, Johnni Winther wrote:
> > Why did this change?
> 
> When I ran `tools/test.py dart2js` it complained. I'm not sure, why this
wasn't
> an issue before.

Removed.

[Brian Wilkerson, 2016-03-07 15:04:02]

LGTM

https://chromiumcodereview.appspot.com/1750143005/diff/40001/pkg/analyzer/lib...
File pkg/analyzer/lib/src/generated/generated/shared_messages.dart (right):

https://chromiumcodereview.appspot.com/1750143005/diff/40001/pkg/analyzer/lib...
pkg/analyzer/lib/src/generated/generated/shared_messages.dart:18: "Try removing
the 'const' keyword or the body.");  // Generated. Don't edit.
Perhaps in a future CL we could remove the generated "// Generated. Don't
edit."; I don't think it adds anything, given that we've already said that once
at the top of the file. Certainly not critical either way.

[floitsch, 2016-03-07 15:07:39]

https://chromiumcodereview.appspot.com/1750143005/diff/40001/pkg/analyzer/lib...
File pkg/analyzer/lib/src/generated/generated/shared_messages.dart (right):

https://chromiumcodereview.appspot.com/1750143005/diff/40001/pkg/analyzer/lib...
pkg/analyzer/lib/src/generated/generated/shared_messages.dart:18: "Try removing
the 'const' keyword or the body.");  // Generated. Don't edit.
On 2016/03/07 15:04:02, Brian Wilkerson wrote:
> Perhaps in a future CL we could remove the generated "// Generated. Don't
> edit."; I don't think it adds anything, given that we've already said that
once
> at the top of the file. Certainly not critical either way.

It's "your" file, and I can remove it. However the problem is, that the IDE
directly jumps to the message (not the top of the file). You could modify a
message, and even commit it, but the change would be lost at the next "publish"
step. If we could make files read-only, I would be more in favor of removing
them.

[Brian Wilkerson, 2016-03-07 15:11:41]

https://chromiumcodereview.appspot.com/1750143005/diff/40001/pkg/analyzer/lib...
File pkg/analyzer/lib/src/generated/generated/shared_messages.dart (right):

https://chromiumcodereview.appspot.com/1750143005/diff/40001/pkg/analyzer/lib...
pkg/analyzer/lib/src/generated/generated/shared_messages.dart:18: "Try removing
the 'const' keyword or the body.");  // Generated. Don't edit.
Fair enough.

Eventually we'll probably do what we've done for our other generated files,
which is to add a test that generates the content of the files and expects it to
match the actual content. That helps us ensure that we didn't forget to
re-generate files when needed and didn't tryto hand-edit generated files.

But for now I'm fine leaving it as is.

[floitsch, 2016-03-07 15:39:17]

Description was changed from

==========
Move more messages.

Migrates some of the 'undefined' messages to the shared file.
==========

to

==========
Move more messages.

Migrates some of the 'undefined' messages to the shared file.

R=brianwilkerson@google.com, johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/dd326beee1b1b4d1437bedb1aea2d6af2378de6f
==========

[floitsch, 2016-03-07 15:39:18]

Committed patchset #3 (id:40001) manually as
dd326beee1b1b4d1437bedb1aea2d6af2378de6f (presubmit successful).