Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/compiler/lib/src/typechecker.dart

Issue 1750143005: Move more messages. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Undo change to analyze_test_test.dart Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/typechecker.dart
diff --git a/pkg/compiler/lib/src/typechecker.dart b/pkg/compiler/lib/src/typechecker.dart
index 71a0fc1bfb225775bd48c2618ce1cac89965571d..ff1e99902989f12d973e06b174e10771bc184888 100644
--- a/pkg/compiler/lib/src/typechecker.dart
+++ b/pkg/compiler/lib/src/typechecker.dart
@@ -829,12 +829,12 @@ class TypeCheckerVisitor extends Visitor<DartType> {
if (!foundPrivateMember) {
switch (memberKind) {
case MemberKind.METHOD:
- reportMessage(node, MessageKind.METHOD_NOT_FOUND,
+ reportMessage(node, MessageKind.UNDEFINED_METHOD,
{'className': receiverType.name, 'memberName': name},
isHint: isHint);
break;
case MemberKind.OPERATOR:
- reportMessage(node, MessageKind.OPERATOR_NOT_FOUND,
+ reportMessage(node, MessageKind.UNDEFINED_OPERATOR,
{'className': receiverType.name, 'memberName': name},
isHint: isHint);
break;
@@ -842,7 +842,7 @@ class TypeCheckerVisitor extends Visitor<DartType> {
if (lookupMemberSignature(memberName.setter, interface) != null) {
// A setter is present so warn explicitly about the missing
// getter.
- reportMessage(node, MessageKind.GETTER_NOT_FOUND,
+ reportMessage(node, MessageKind.UNDEFINED_INSTANCE_GETTER_BUT_SETTER,
{'className': receiverType.name, 'memberName': name},
isHint: isHint);
} else if (name == 'await') {
@@ -857,13 +857,13 @@ class TypeCheckerVisitor extends Visitor<DartType> {
}
reportMessage(node, kind, arguments, isHint: isHint);
} else {
- reportMessage(node, MessageKind.MEMBER_NOT_FOUND,
+ reportMessage(node, MessageKind.UNDEFINED_GETTER,
{'className': receiverType.name, 'memberName': name},
isHint: isHint);
}
break;
case MemberKind.SETTER:
- reportMessage(node, MessageKind.SETTER_NOT_FOUND,
+ reportMessage(node, MessageKind.UNDEFINED_SETTER,
{'className': receiverType.name, 'memberName': name},
isHint: isHint);
break;

Powered by Google App Engine
This is Rietveld 408576698