Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Unified Diff: chrome/common/render_messages.h

Issue 1750113002: Remove "Show saved copy" button from error page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/render_messages.h
diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h
index e71787700eecf074957b3df4706fe26477033fe9..b41aeabc1de67c75b81afdedbdeeff89aadcc394 100644
--- a/chrome/common/render_messages.h
+++ b/chrome/common/render_messages.h
@@ -16,7 +16,6 @@
#include "chrome/common/ntp_logging_events.h"
#include "chrome/common/search_provider.h"
#include "chrome/common/web_application_info.h"
-#include "components/error_page/common/offline_page_types.h"
#include "components/omnibox/common/omnibox_focus_state.h"
#include "content/public/common/common_param_traits.h"
#include "content/public/common/top_controls_state.h"
@@ -78,9 +77,6 @@ IPC_ENUM_TRAITS_MAX_VALUE(blink::WebConsoleMessage::Level,
blink::WebConsoleMessage::LevelLast)
IPC_ENUM_TRAITS_MAX_VALUE(content::TopControlsState,
content::TOP_CONTROLS_STATE_LAST)
-IPC_ENUM_TRAITS_MAX_VALUE(
- error_page::OfflinePageStatus,
- error_page::OfflinePageStatus::OFFLINE_PAGE_STATUS_LAST)
// Output parameters for ChromeViewHostMsg_GetPluginInfo message.
IPC_STRUCT_BEGIN(ChromeViewHostMsg_GetPluginInfo_Output)
@@ -320,10 +316,10 @@ IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetCanShowNetworkDiagnosticsDialog,
bool /* can_show_network_diagnostics_dialog */)
#if defined(OS_ANDROID)
-// Tells the renderer about the status of the offline pages. This is used to
+// Tells the renderer whether or not an offline page exists. This is used to
// decide if offline related button will be provided on certain error page.
nasko 2016/03/01 22:23:10 I thought this CL is aiming to remove the button.
jianli 2016/03/01 22:53:16 We're removing "Show saved copy" button, but not "
-IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetOfflinePageInfo,
- error_page::OfflinePageStatus /* offline_page_status */)
+IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetHasOfflinePages,
+ bool /* has_offline_pages */)
#endif // defined(OS_ANDROID)
// Provides the information needed by the renderer process to contact a
@@ -342,10 +338,6 @@ IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_RunNetworkDiagnostics,
// Message sent from the renderer to the browser to show the UI for offline
// pages.
IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_ShowOfflinePages)
-
-// Message sent from the renderer to the browser to load the offline copy of
-// the page that fails to load due to no network connectivity.
-IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_LoadOfflineCopy, GURL /* url */)
#endif // defined(OS_ANDROID)
//-----------------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698