Remove "Show saved copy" button from error page

chrome/common/render_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included file, no traditional include guard.
 #include <stdint.h>
 #include <string>
 #include <vector>
 
 #include "base/files/file_path.h"
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "chrome/common/common_param_traits.h"
 #include "chrome/common/instant_types.h"
 #include "chrome/common/ntp_logging_events.h"
 #include "chrome/common/search_provider.h"
 #include "chrome/common/web_application_info.h"
-#include "components/error_page/common/offline_page_types.h"
 #include "components/omnibox/common/omnibox_focus_state.h"
 #include "content/public/common/common_param_traits.h"
 #include "content/public/common/top_controls_state.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_platform_file.h"
 #include "third_party/WebKit/public/platform/modules/app_banner/WebAppBannerPromptReply.h"
 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
 
 // Singly-included section for enums and custom IPC traits.
@@ skipping 41 matching lines @@
 IPC_ENUM_TRAITS_MIN_MAX_VALUE(search_provider::InstallState,
                               search_provider::DENIED,
                               search_provider::INSTALLED_STATE_LAST)
 IPC_ENUM_TRAITS_MAX_VALUE(ThemeBackgroundImageAlignment,
                           THEME_BKGRND_IMAGE_ALIGN_LAST)
 IPC_ENUM_TRAITS_MAX_VALUE(ThemeBackgroundImageTiling, THEME_BKGRND_IMAGE_LAST)
 IPC_ENUM_TRAITS_MAX_VALUE(blink::WebConsoleMessage::Level,
                           blink::WebConsoleMessage::LevelLast)
 IPC_ENUM_TRAITS_MAX_VALUE(content::TopControlsState,
                           content::TOP_CONTROLS_STATE_LAST)
-IPC_ENUM_TRAITS_MAX_VALUE(
-    error_page::OfflinePageStatus,
-    error_page::OfflinePageStatus::OFFLINE_PAGE_STATUS_LAST)
 
 // Output parameters for ChromeViewHostMsg_GetPluginInfo message.
 IPC_STRUCT_BEGIN(ChromeViewHostMsg_GetPluginInfo_Output)
   IPC_STRUCT_MEMBER(ChromeViewHostMsg_GetPluginInfo_Status, status)
   IPC_STRUCT_MEMBER(content::WebPluginInfo, plugin)
   IPC_STRUCT_MEMBER(std::string, actual_mime_type)
   IPC_STRUCT_MEMBER(std::string, group_identifier)
   IPC_STRUCT_MEMBER(base::string16, group_name)
 IPC_STRUCT_END()
 
@@ skipping 219 matching lines @@
 // page with more specific troubleshooting suggestions.
 IPC_MESSAGE_ROUTED1(ChromeViewMsg_NetErrorInfo,
                     int /* DNS probe status */)
 
 // Tells the renderer whether or not there is a local diagnostics service that
 // can be run via ChromeViewHostMsg_RunNetworkDiagnostics messages.
 IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetCanShowNetworkDiagnosticsDialog,
                     bool /* can_show_network_diagnostics_dialog */)
 
 #if defined(OS_ANDROID)
-// Tells the renderer about the status of the offline pages. This is used to
+// Tells the renderer whether or not an offline page exists. This is used to
 // decide if offline related button will be provided on certain error page.

[nasko, 2016/03/01 22:23:10]

I thought this CL is aiming to remove the button. Should this comment be updated
to reflect that part too?

[jianli, 2016/03/01 22:53:16]

We're removing "Show saved copy" button, but not "Show offline bookmarks" button
which will still be served when any offline page exists. Updated the comment
here to make it a bit better.

-IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetOfflinePageInfo,
-                    error_page::OfflinePageStatus /* offline_page_status */)
+IPC_MESSAGE_ROUTED1(ChromeViewMsg_SetHasOfflinePages,
+                    bool /* has_offline_pages */)
 #endif  // defined(OS_ANDROID)
 
 // Provides the information needed by the renderer process to contact a
 // navigation correction service.  Handled by the NetErrorHelper.
 IPC_MESSAGE_ROUTED5(ChromeViewMsg_SetNavigationCorrectionInfo,
                     GURL /* Navigation correction service base URL */,
                     std::string /* language */,
                     std::string /* origin_country */,
                     std::string /* API key to use */,
                     GURL /* Google Search URL to use */)
 
 IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_RunNetworkDiagnostics,
                     GURL /* failed_url */)
 
 #if defined(OS_ANDROID)
 // Message sent from the renderer to the browser to show the UI for offline
 // pages.
 IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_ShowOfflinePages)
-
-// Message sent from the renderer to the browser to load the offline copy of
-// the page that fails to load due to no network connectivity.
-IPC_MESSAGE_ROUTED1(ChromeViewHostMsg_LoadOfflineCopy, GURL /* url */)
 #endif  // defined(OS_ANDROID)
 
 //-----------------------------------------------------------------------------
 // Misc messages
 // These are messages sent from the renderer to the browser process.
 
 IPC_MESSAGE_CONTROL5(ChromeViewHostMsg_UpdatedCacheStats,
                      uint64_t /* min_dead_capacity */,
                      uint64_t /* max_dead_capacity */,
                      uint64_t /* capacity */,
@@ skipping 220 matching lines @@
 
 // Record a sample string to a Rappor metric.
 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRappor,
                      std::string /* metric */,
                      std::string /* sample */)
 
 // Record a domain and registry of a url to a Rappor metric.
 IPC_MESSAGE_CONTROL2(ChromeViewHostMsg_RecordRapporURL,
                      std::string /* metric */,
                      GURL /* sample url */)