Replicate static layout test configuration to all renderers.

Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.  This CL will ensure that OOPIFs will have a correct value
of BlinkTestRunner::is_main_windows_, BlinkTestRunner::test_config_ and
other test flags that stay constant throughout the test.  This CL also
paves the way for replicating dynamic test flags (i.e. dump_as_text or
wait_until_done) across OOPIFs in a future CL (i.e. the work-in-progress
CL at crrev.com/1715573002).

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.  The first message in a test will be a
ShellViewMsg_SetTestConfiguration;  all subsequent renderers get
ShellViewMsg_ReplicateTestConfiguration (differentiation is needed to
avoid executing test initialization activities twice).

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175
Committed: https://crrev.com/692a9e9ca5bb6d48b1d3c1e565be7205034e9a39
Cr-Commit-Position: refs/heads/master@{#379992}

[Łukasz Anforowicz, 2016-03-02 23:57:28]

Description was changed from

==========
Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175
==========

to

==========
Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.  The first message in a test will be a
ShellViewMsg_SetTestConfiguration;  all subsequent renderers get
ShellViewMsg_ReplicateTestConfiguration (differentiation is needed to
avoid executing test initialization activities twice).

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175
==========

[Łukasz Anforowicz, 2016-03-03 18:44:38]

Description was changed from

==========
Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.  The first message in a test will be a
ShellViewMsg_SetTestConfiguration;  all subsequent renderers get
ShellViewMsg_ReplicateTestConfiguration (differentiation is needed to
avoid executing test initialization activities twice).

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175
==========

to

==========
Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.  This CL will ensure that OOPIFs will have a correct value
of BlinkTestRunner::is_main_windows_, BlinkTestRunner::test_config_ and
other test flags that stay constant throughout the test.  This CL also
paves the way for replicating dynamic test flags (i.e. dump_as_text or
wait_until_done) across OOPIFs (work-in-progress CL at
crrev.com/1715573002).

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.  The first message in a test will be a
ShellViewMsg_SetTestConfiguration;  all subsequent renderers get
ShellViewMsg_ReplicateTestConfiguration (differentiation is needed to
avoid executing test initialization activities twice).

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175
==========

[Łukasz Anforowicz, 2016-03-03 18:58:00]

Description was changed from

==========
Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.  This CL will ensure that OOPIFs will have a correct value
of BlinkTestRunner::is_main_windows_, BlinkTestRunner::test_config_ and
other test flags that stay constant throughout the test.  This CL also
paves the way for replicating dynamic test flags (i.e. dump_as_text or
wait_until_done) across OOPIFs (work-in-progress CL at
crrev.com/1715573002).

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.  The first message in a test will be a
ShellViewMsg_SetTestConfiguration;  all subsequent renderers get
ShellViewMsg_ReplicateTestConfiguration (differentiation is needed to
avoid executing test initialization activities twice).

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175
==========

to

==========
Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.  This CL will ensure that OOPIFs will have a correct value
of BlinkTestRunner::is_main_windows_, BlinkTestRunner::test_config_ and
other test flags that stay constant throughout the test.  This CL also
paves the way for replicating dynamic test flags (i.e. dump_as_text or
wait_until_done) across OOPIFs in a future CL (i.e. the work-in-progress
CL at crrev.com/1715573002).

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.  The first message in a test will be a
ShellViewMsg_SetTestConfiguration;  all subsequent renderers get
ShellViewMsg_ReplicateTestConfiguration (differentiation is needed to
avoid executing test initialization activities twice).

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175
==========

[Łukasz Anforowicz, 2016-03-03 19:00:44]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-03 19:00:45]

jochen@, can you take a look please?

[jochen (gone - plz use gerrit), 2016-03-04 12:36:55]

i'd expect that you also need to install notify_done_forwarders for all iframes,
or is that already done?

https://codereview.chromium.org/1750063002/diff/20001/content/shell/renderer/...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1750063002/diff/20001/content/shell/renderer/...
content/shell/renderer/layout_test/blink_test_runner.cc:979: is_main_window_ =
true;
there can only be one main window, but now all OOPIF think they're the main
window?

[Łukasz Anforowicz, 2016-03-04 20:49:45]

On 2016/03/04 12:36:55, jochen wrote:
> i'd expect that you also need to install notify_done_forwarders for all
iframes,
> or is that already done?
> 
Good point.  I was kind of doing a similar thing in
https://codereview.chromium.org/1765623003/#ps1 by "declaring" handling of this
message in BlinkTestController::OnMessageReceived, but your suggestion to reuse
NotifyDoneForwarder seems cleaner and nicer.  I've updated
https://codereview.chromium.org/1765623003 to reuse NotifyDoneForwarded.

Your feedback also raises the question of how to split things into individual
CLs.  Maybe I should combine https://codereview.chromium.org/1765623003 and
https://codereview.chromium.org/1746393002...  I need to check if tests continue
to pass if the CLs are sliced/split differently (I suspect they won't, but let
me double-check).  At any rate - I think the current CL under review is fine as
a standalone CL.

https://codereview.chromium.org/1750063002/diff/20001/content/shell/renderer/...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/1750063002/diff/20001/content/shell/renderer/...
content/shell/renderer/layout_test/blink_test_runner.cc:979: is_main_window_ =
true;
On 2016/03/04 12:36:55, jochen wrote:
> there can only be one main window, but now all OOPIF think they're the main
> window?

I've addressed your other, similar question here:
https://codereview.chromium.org/1746393002/diff/20001/content/shell/renderer/...

[jochen (gone - plz use gerrit), 2016-03-08 16:28:58]

lgtm no matter what you name the variable

https://codereview.chromium.org/1750063002/diff/40001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/1750063002/diff/40001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.h:231: bool
need_to_send_test_configuration_to_renderer_;
the name is a bit confusing, because in fact you'll send the configuration
whether this variable is true or false. It's only telling which IPC you'll
use...

[Łukasz Anforowicz, 2016-03-08 17:33:30]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-03-08 17:33:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 17:33:45]

This CL has an open dependency (Issue 1746393002 Patch 40001). Please resolve
the dependency and try again.

[Łukasz Anforowicz, 2016-03-08 17:41:11]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-03-08 18:12:46]

Thanks for reviewing.

https://codereview.chromium.org/1750063002/diff/40001/content/shell/browser/l...
File content/shell/browser/layout_test/blink_test_controller.h (right):

https://codereview.chromium.org/1750063002/diff/40001/content/shell/browser/l...
content/shell/browser/layout_test/blink_test_controller.h:231: bool
need_to_send_test_configuration_to_renderer_;
On 2016/03/08 16:28:58, jochen wrote:
> the name is a bit confusing, because in fact you'll send the configuration
> whether this variable is true or false. It's only telling which IPC you'll
> use...

Done.  I talked with alexmos@ and he helped me pick
|did_send_initial_test_configuration_| as the new name (with value semantics
reversed compared to the old name).

[Łukasz Anforowicz, 2016-03-08 20:49:29]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-03-08 20:49:29]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1750063002/#ps80001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-03-08 20:49:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750063002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750063002/80001

[commit-bot: I haz the power, 2016-03-09 00:28:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-09 00:29:31]

Description was changed from

==========
Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.  This CL will ensure that OOPIFs will have a correct value
of BlinkTestRunner::is_main_windows_, BlinkTestRunner::test_config_ and
other test flags that stay constant throughout the test.  This CL also
paves the way for replicating dynamic test flags (i.e. dump_as_text or
wait_until_done) across OOPIFs in a future CL (i.e. the work-in-progress
CL at crrev.com/1715573002).

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.  The first message in a test will be a
ShellViewMsg_SetTestConfiguration;  all subsequent renderers get
ShellViewMsg_ReplicateTestConfiguration (differentiation is needed to
avoid executing test initialization activities twice).

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175
==========

to

==========
Replicate static layout test configuration to all renderers.

Currently BlinkTestController sends test configuration whenever the
RenderView gets a new host.  This is insufficient in the long term - we
also need to send test configuration to renderers that do not host the
main frame.  This CL will ensure that OOPIFs will have a correct value
of BlinkTestRunner::is_main_windows_, BlinkTestRunner::test_config_ and
other test flags that stay constant throughout the test.  This CL also
paves the way for replicating dynamic test flags (i.e. dump_as_text or
wait_until_done) across OOPIFs in a future CL (i.e. the work-in-progress
CL at crrev.com/1715573002).

BlinkTestController already tracks all RenderProcessHosts to make sure
it can detect a crash not only in the main frame, but also in OOPIFs.
This CL extends this tracking to also send test configuration to new
RenderProcessHosts.  The first message in a test will be a
ShellViewMsg_SetTestConfiguration;  all subsequent renderers get
ShellViewMsg_ReplicateTestConfiguration (differentiation is needed to
avoid executing test initialization activities twice).

The test configuration ultimately needs to reach a BlinkTestRunner
instance in a specific RenderProcess.  The CL accomplishes this by
sending a message to a RenderFrame known to be present in a new
RenderProcess - the message is received by LayoutTestRenderFrameObserver
and forwarded to the BlinkTestRunner singleton in the current process.
Other alternatives have been ruled out:
- Sending a message to a RenderView in a specific process is not
  possible outside of //content internals.
- There is no way for BlinkTestRunner to intercept a message to a
  RenderProcess.

The CL reuses BlinkTestController::send_configuration_to_next_host_
field to track whether it has already send the test configuration
to any render hosts.  The new code seems consistent with the spirit
of https://crrev.com/12595002 which introduced this field.

BUG=587175

Committed: https://crrev.com/692a9e9ca5bb6d48b1d3c1e565be7205034e9a39
Cr-Commit-Position: refs/heads/master@{#379992}
==========

[commit-bot: I haz the power, 2016-03-09 00:29:32]

Patchset 5 (id:??) landed as
https://crrev.com/692a9e9ca5bb6d48b1d3c1e565be7205034e9a39
Cr-Commit-Position: refs/heads/master@{#379992}