Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2236)

Unified Diff: content/shell/browser/layout_test/blink_test_controller.h

Issue 1750063002: Replicate static layout test configuration to all renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-test-finished-in-secondary-frames-please
Patch Set: Rebasing... Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/shell/browser/layout_test/blink_test_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/layout_test/blink_test_controller.h
diff --git a/content/shell/browser/layout_test/blink_test_controller.h b/content/shell/browser/layout_test/blink_test_controller.h
index 6ff85f72d26255f663aa419bae69b87c04687893..165d09f38552462c95340642c4ea97daa7f50bfc 100644
--- a/content/shell/browser/layout_test/blink_test_controller.h
+++ b/content/shell/browser/layout_test/blink_test_controller.h
@@ -187,7 +187,8 @@ class BlinkTestController : public base::NonThreadSafe,
static BlinkTestController* instance_;
void DiscardMainWindow();
- void SendTestConfiguration();
+ void HandleNewRenderFrameHost(
+ RenderFrameHost* frame_representing_target_process);
// Message handlers.
void OnAudioDump(const std::vector<unsigned char>& audio_dump);
@@ -225,9 +226,11 @@ class BlinkTestController : public base::NonThreadSafe,
// The PID of the render process of the render view host of main_window_.
int current_pid_;
- // True if we should set the test configuration to the next RenderViewHost
- // created.
- bool send_configuration_to_next_host_;
+ // Tracks if (during the current test) we have already sent *initial* test
+ // configuration to a renderer process (*initial* test configuration is
+ // associated with some steps that should only be executed *once* per test -
+ // for example resizing the window and setting the focus).
+ bool did_send_initial_test_configuration_;
// What phase of running an individual test we are currently in.
TestPhase test_phase_;
« no previous file with comments | « no previous file | content/shell/browser/layout_test/blink_test_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698