Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/gtk/bookmark_menu_controller_gtk.cc

Issue 175004: Ellipsize long entries in bookmark menus and the back/forward menus.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/gtk/bookmark_menu_controller_gtk.cc
===================================================================
--- chrome/browser/gtk/bookmark_menu_controller_gtk.cc (revision 24583)
+++ chrome/browser/gtk/bookmark_menu_controller_gtk.cc (working copy)
@@ -27,6 +27,9 @@
namespace {
+// TODO(estade): It might be a good idea to vary this by locale.
+const int kMaxChars = 50;
+
void SetImageMenuItem(GtkWidget* menu_item, const SkBitmap& bitmap) {
GdkPixbuf* pixbuf = gfx::GdkPixbufFromSkBitmap(&bitmap);
gtk_image_menu_item_set_image(GTK_IMAGE_MENU_ITEM(menu_item),
@@ -150,8 +153,12 @@
for (int i = start_child_index; i < parent->GetChildCount(); ++i) {
const BookmarkNode* node = parent->GetChild(i);
- GtkWidget* menu_item = gtk_image_menu_item_new_with_label(
- WideToUTF8(node->GetTitle()).c_str());
+ // This breaks on word boundaries. Ideally we would break on character
+ // boundaries.
+ std::wstring elided_name =
+ l10n_util::TruncateString(node->GetTitle(), kMaxChars);
+ GtkWidget* menu_item =
+ gtk_image_menu_item_new_with_label(WideToUTF8(elided_name).c_str());
g_object_set_data(G_OBJECT(menu_item), "bookmark-node", AsVoid(node));
if (node->is_url()) {

Powered by Google App Engine
This is Rietveld 408576698