components/web_modal/web_contents_modal_dialog_manager.h - Issue 17500003: Close web contents modal dialogs on content load start

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 17500003: Close web contents modal dialogs on content load start (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/web_modal/web_contents_modal_dialog_manager.h

diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h

index e2548c04e5cfc8b48bef516d9048aefea4f03052..a16869394cecd86c190f3b5743c2687dbd3939fa 100644

--- a/components/web_modal/web_contents_modal_dialog_manager.h

+++ b/components/web_modal/web_contents_modal_dialog_manager.h

@@ -87,9 +87,6 @@ class WebContentsModalDialogManager

void CloseAllDialogs();

// Overridden from content::WebContentsObserver:

- virtual void DidNavigateMainFrame(

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) OVERRIDE;

virtual void DidGetIgnoredUIEvent() OVERRIDE;

virtual void WebContentsDestroyed(content::WebContents* tab) OVERRIDE;