Close web contents modal dialogs on content load start

chrome/browser/printing/print_view_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_view_manager.h"
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 135 matching lines @@
   return true;
 }
 
 void PrintViewManager::PrintPreviewForWebNode() {
   DCHECK_EQ(NOT_PREVIEWING, print_preview_state_);
   print_preview_state_ = USER_INITIATED_PREVIEW;
 }
 
 void PrintViewManager::PrintPreviewDone() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-  DCHECK_NE(NOT_PREVIEWING, print_preview_state_);

[Lei Zhang, 2013/06/27 02:28:46]

If I put this DCHECK back, I can't seem to trigger it, at least on Linux views.
That is, PrintPreviewDone() always gets called for me before RenderViewGone().
Is there a specific set of steps that reliably triggers this for you? I can try
those steps, or try on Windows.

[Mike Wittman, 2013/06/27 17:34:04]

I didn't experience this DCHECK firing while running Chrome, but it does so
reliably with the
PrintPreviewDialogControllerBrowserTest.NavigateFromInitiatorTab browser test.

[Lei Zhang, 2013/06/27 21:36:18]

No luck for me on Linux-views. I'll fire up the Windoze box and get back to
you...

 
   if (print_preview_state_ == SCRIPTED_PREVIEW) {
     ScriptedPrintPreviewClosureMap& map =
         g_scripted_print_preview_closure_map.Get();
     ScriptedPrintPreviewClosureMap::iterator it =
         map.find(scripted_print_preview_rph_);
     CHECK(it != map.end());
     it->second.Run();
     map.erase(scripted_print_preview_rph_);
     scripted_print_preview_rph_ = NULL;
@@ skipping 509 matching lines @@
   scoped_refptr<printing::PrinterQuery> printer_query;
   print_job_manager->PopPrinterQuery(cookie, &printer_query);
   if (!printer_query.get())
     return;
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&PrinterQuery::StopWorker, printer_query.get()));
 }
 
 }  // namespace printing