Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1749893002: Fix Smart Lock bugs introduced by change from raw email to AccountId. (Closed)

Created:
4 years, 9 months ago by Tim Song
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Fix Smart Lock bugs introduced by change from raw email to AccountId. BUG=585672 TEST=verified on link Review URL: https://codereview.chromium.org/1734243003 Cr-Commit-Position: refs/heads/master@{#378002} (cherry picked from commit b2b328b08f644cc4e6557aa36502b25558997b44) Committed: https://chromium.googlesource.com/chromium/src/+/601d5f3bedad31bca5661aced7ecbf8d32293291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc View 5 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Tim Song
4 years, 9 months ago (2016-02-29 19:41:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
601d5f3bedad31bca5661aced7ecbf8d32293291.

Powered by Google App Engine
This is Rietveld 408576698