Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1734243003: Fix Smart Lock bugs introduced by change from raw email to AccountId. (Closed)

Created:
4 years, 9 months ago by Tim Song
Modified:
4 years, 9 months ago
Reviewers:
sacomoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Smart Lock bugs introduced by change from raw email to AccountId. BUG=585672 TEST=verified on link Committed: https://crrev.com/b2b328b08f644cc4e6557aa36502b25558997b44 Cr-Commit-Position: refs/heads/master@{#378002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc View 5 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tim Song
4 years, 9 months ago (2016-02-26 00:00:21 UTC) #3
sacomoto
lgtm
4 years, 9 months ago (2016-02-26 13:41:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1734243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1734243003/1
4 years, 9 months ago (2016-02-26 21:31:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-26 22:18:06 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 22:19:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2b328b08f644cc4e6557aa36502b25558997b44
Cr-Commit-Position: refs/heads/master@{#378002}

Powered by Google App Engine
This is Rietveld 408576698