Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1749803002: [Smart Lock, UI] Drop unused strings from explanation for Autosign in. (Closed)

Created:
4 years, 9 months ago by melandory
Modified:
4 years, 9 months ago
Reviewers:
vasilii
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@first_run_explanation_fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock, UI] Drop unused strings from explanation for Autosign in. BUG=none Committed: https://crrev.com/071c61af4d632a6d314a0309791418b2a1fd4126 Cr-Commit-Position: refs/heads/master@{#378304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1743263002 Patch 1

Messages

Total messages: 15 (7 generated)
melandory
4 years, 9 months ago (2016-02-29 17:26:24 UTC) #2
vasilii
lgtm
4 years, 9 months ago (2016-02-29 17:27:46 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1743263002 Patch 1). Please resolve the dependency and ...
4 years, 9 months ago (2016-02-29 17:50:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749803002/1
4 years, 9 months ago (2016-02-29 18:03:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/181349)
4 years, 9 months ago (2016-02-29 18:12:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749803002/1
4 years, 9 months ago (2016-02-29 21:53:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 23:06:11 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 23:07:34 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/071c61af4d632a6d314a0309791418b2a1fd4126
Cr-Commit-Position: refs/heads/master@{#378304}

Powered by Google App Engine
This is Rietveld 408576698