Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1743263002: [Smart Lock, UI] Auto sign-in first run dialog should use new strings. (Closed)

Created:
4 years, 9 months ago by melandory
Modified:
4 years, 9 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock, UI] Auto sign-in first run dialog should use new strings. Auto sign-in first run dialog should use new strings for the explanation text. BUG=590763 Committed: https://crrev.com/b0a5e3271af5d8a5b8237915acd08a5dc07c8a4d Cr-Commit-Position: refs/heads/master@{#378229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/password_manager/auto_signin_first_run_dialog_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (5 generated)
melandory
PTAL, thank!
4 years, 9 months ago (2016-02-29 16:38:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743263002/1
4 years, 9 months ago (2016-02-29 16:47:08 UTC) #4
vasilii
Drop the previous strings from resources.
4 years, 9 months ago (2016-02-29 17:14:47 UTC) #5
melandory
On 2016/02/29 17:14:47, vasilii wrote: > Drop the previous strings from resources. As separate patch ...
4 years, 9 months ago (2016-02-29 17:25:35 UTC) #6
melandory
On 2016/02/29 17:14:47, vasilii wrote: > Drop the previous strings from resources. As separate patch ...
4 years, 9 months ago (2016-02-29 17:25:38 UTC) #7
vasilii
lgtm
4 years, 9 months ago (2016-02-29 17:27:29 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 17:32:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1743263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1743263002/1
4 years, 9 months ago (2016-02-29 17:50:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 17:55:46 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 17:57:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0a5e3271af5d8a5b8237915acd08a5dc07c8a4d
Cr-Commit-Position: refs/heads/master@{#378229}

Powered by Google App Engine
This is Rietveld 408576698