Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1749763002: Use enclosing int rect for picture shader tiles (Closed)

Created:
4 years, 9 months ago by f(malita)
Modified:
4 years, 9 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : toCeil #

Patch Set 3 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/core/SkPictureShader.cpp View 1 2 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
f(malita)
4 years, 9 months ago (2016-02-29 16:33:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749763002/1
4 years, 9 months ago (2016-02-29 16:33:42 UTC) #4
f(malita)
On 2016/02/29 16:33:28, f(malita) wrote: > Rounding seems correct in the general case Actually, SkPictureShader ...
4 years, 9 months ago (2016-02-29 16:41:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749763002/20001
4 years, 9 months ago (2016-02-29 16:41:44 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749763002/40001
4 years, 9 months ago (2016-02-29 16:45:35 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-29 17:01:30 UTC) #12
reed1
lgtm
4 years, 9 months ago (2016-02-29 17:11:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749763002/40001
4 years, 9 months ago (2016-02-29 17:16:18 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 17:18:33 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/85c6f9849ed72f859680e93e7d24e3f61ff280f9

Powered by Google App Engine
This is Rietveld 408576698