Issue 174943003: Revert 252502 "Fixes DesktopScreenX11::GetWindowAtScreenPoint() ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174943003: Revert 252502 "Fixes DesktopScreenX11::GetWindowAtScreenPoint() ..." (Closed)

Created:
6 years, 10 months ago by Jói

Modified:
6 years, 10 months ago

Reviewers:
pkotwicz

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 252502 "Fixes DesktopScreenX11::GetWindowAtScreenPoint() ..." Reason for revert: DesktopScreenX11Test.GetWindowAtScreenPoint started failing on a few bots after this change. > Fixes DesktopScreenX11::GetWindowAtScreenPoint() so that NULL is returned if a chrome browser window is occluded by a non Chrome app at the passed in point > > BUG=339587 > TEST=Manual, see bug > > Review URL: https://codereview.chromium.org/173193006 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252521

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -46 lines)			Patch
	M	trunk/src/ui/views/widget/desktop_aura/desktop_screen_x11.cc	View		2 chunks	+10 lines, -46 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jói

6 years, 10 months ago (2014-02-21 09:41:37 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r252521 (tree was closed).

Expand Messages | Collapse Messages