Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 173193006: Make DesktopScreenX11::GetWindowAtScreenPoint() take non-Chrome windows into account (Closed)

Created:
6 years, 10 months ago by pkotwicz
Modified:
6 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Visibility:
Public.

Description

Fixes DesktopScreenX11::GetWindowAtScreenPoint() so that NULL is returned if a chrome browser window is occluded by a non Chrome app at the passed in point BUG=339587 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252502

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 2 chunks +46 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pkotwicz
erg@, can you please take a look? This CL seems to fix crbug.com/339587 https://codereview.chromium.org/173193006/diff/50001/ui/views/widget/desktop_aura/desktop_screen_x11.cc File ...
6 years, 10 months ago (2014-02-20 03:01:54 UTC) #1
Elliot Glaysher
lgtm https://codereview.chromium.org/173193006/diff/50001/ui/views/widget/desktop_aura/desktop_screen_x11.cc File ui/views/widget/desktop_aura/desktop_screen_x11.cc (right): https://codereview.chromium.org/173193006/diff/50001/ui/views/widget/desktop_aura/desktop_screen_x11.cc#newcode95 ui/views/widget/desktop_aura/desktop_screen_x11.cc:95: ui::WindowContainsPoint(xid, screen_loc_)) { On 2014/02/20 03:01:55, pkotwicz wrote: ...
6 years, 10 months ago (2014-02-20 18:30:08 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-20 22:21:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/173193006/100001
6 years, 10 months ago (2014-02-20 22:24:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 22:45:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-20 22:45:02 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-20 22:50:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/173193006/100001
6 years, 10 months ago (2014-02-20 22:53:03 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 22:55:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 10 months ago (2014-02-20 22:55:39 UTC) #10
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-21 02:11:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/173193006/100001
6 years, 10 months ago (2014-02-21 02:13:41 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 05:29:33 UTC) #13
Message was sent while issue was closed.
Change committed as 252502

Powered by Google App Engine
This is Rietveld 408576698