Implement BluetoothRemoteGattCharacteristicWin::StartNotifySession and related unit tests

device/bluetooth/bluetooth_remote_gatt_characteristic_win.h

Index: device/bluetooth/bluetooth_remote_gatt_characteristic_win.h
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h
index bf37ccc17e8a470acdf7a2c495b9173f4358a1ed..4b77ead7301fd7bab9ae2e9f12138883717e0e2c 100644
--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h
+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_win.h
@@ -80,6 +80,11 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicWin
       HRESULT hr);
   void OnWriteRemoteCharacteristicValueCallback(HRESULT hr);
   BluetoothGattService::GattErrorCode HRESULTToGattErrorCode(HRESULT hr);
+  void OnGattCharacteristicValueChanged(
+      scoped_ptr<std::vector<uint8_t>> new_value);
+  void GattEventRegistrationCallback(PVOID event_handle, HRESULT hr);
+  void StartNotifySession();

[ortuno, 2016/03/30 22:34:23]

There are now two functions called StartNotifySession which is very confusing.
Please change this name to make it clearer what this function does.

Also comment what the function does.

[gogerald1, 2016/03/31 17:44:13]

Done. no longer needed.

+  void ClearIncludedDescriptors();
 
   BluetoothRemoteGattServiceWin* parent_service_;
   scoped_refptr<BluetoothTaskManagerWin> task_manager_;
@@ -98,6 +103,12 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicWin
       GattDescriptorMap;
   GattDescriptorMap included_descriptors_;
 
+  // Flag indicates if get included descriptors has been completed.
+  bool included_descriptors_discovered_;
+
+  // Identifier of the Client Characteristic Configuration descriptor;
+  std::string ccc_descriptor_identifier_;
+
   // Flag indicates if characteristic added notification of this characteristic
   // has been sent out to avoid duplicate notification.
   bool characteristic_added_notified_;
@@ -110,6 +121,16 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothRemoteGattCharacteristicWin
 
   bool characteristic_value_read_or_write_in_progress_;
 
+  // Vector stores StartNotifySession request callbacks.
+  std::vector<std::pair<NotifySessionCallback, ErrorCallback>>
+      start_notify_session_callbacks_;
+
+  // Flag indicates if GATT event registration is in progress.
+  bool gatt_event_registeration_in_progress_;
+
+  // GATT event handle returned by GattEventRegistrationCallback.
+  PVOID gatt_event_handle_;
+
   base::WeakPtrFactory<BluetoothRemoteGattCharacteristicWin> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristicWin);
 };