Implement BluetoothRemoteGattCharacteristicWin::StartNotifySession and related unit tests

device/bluetooth/bluetooth_remote_gatt_characteristic_win.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_
 #define DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_
 
 #include <unordered_map>
 
 #include "base/memory/weak_ptr.h"
@@ skipping 62 matching lines @@
   // newly discovered |num| of |descriptors|.
   static bool DoesDescriptorExist(PBTH_LE_GATT_DESCRIPTOR descriptors,
                                   uint16_t num,
                                   BluetoothRemoteGattDescriptorWin* descriptor);
 
   void OnReadRemoteCharacteristicValueCallback(
       scoped_ptr<BTH_LE_GATT_CHARACTERISTIC_VALUE> value,
       HRESULT hr);
   void OnWriteRemoteCharacteristicValueCallback(HRESULT hr);
   BluetoothGattService::GattErrorCode HRESULTToGattErrorCode(HRESULT hr);
+  void OnGattCharacteristicValueChanged(
+      scoped_ptr<std::vector<uint8_t>> new_value);
+  void GattEventRegistrationCallback(PVOID event_handle, HRESULT hr);
+  void StartNotifySession();

[ortuno, 2016/03/30 22:34:23]

There are now two functions called StartNotifySession which is very confusing.
Please change this name to make it clearer what this function does.

Also comment what the function does.

[gogerald1, 2016/03/31 17:44:13]

Done. no longer needed.

+  void ClearIncludedDescriptors();
 
   BluetoothRemoteGattServiceWin* parent_service_;
   scoped_refptr<BluetoothTaskManagerWin> task_manager_;
 
   // Characteristic info from OS and used to interact with OS.
   scoped_ptr<BTH_LE_GATT_CHARACTERISTIC> characteristic_info_;
   scoped_refptr<base::SequencedTaskRunner> ui_task_runner_;
   BluetoothUUID characteristic_uuid_;
   std::vector<uint8_t> characteristic_value_;
   std::string characteristic_identifier_;
 
   // The key of GattDescriptorMap is the identitfier of
   // BluetoothRemoteGattDescriptorWin instance.
   typedef std::unordered_map<std::string,
                              scoped_ptr<BluetoothRemoteGattDescriptorWin>>
       GattDescriptorMap;
   GattDescriptorMap included_descriptors_;
 
+  // Flag indicates if get included descriptors has been completed.
+  bool included_descriptors_discovered_;
+
+  // Identifier of the Client Characteristic Configuration descriptor;
+  std::string ccc_descriptor_identifier_;
+
   // Flag indicates if characteristic added notification of this characteristic
   // has been sent out to avoid duplicate notification.
   bool characteristic_added_notified_;
 
   // ReadRemoteCharacteristic request callbacks.
   std::pair<ValueCallback, ErrorCallback> read_characteristic_value_callbacks_;
 
   // WriteRemoteCharacteristic request callbacks.
   std::pair<base::Closure, ErrorCallback> write_characteristic_value_callbacks_;
 
   bool characteristic_value_read_or_write_in_progress_;
 
+  // Vector stores StartNotifySession request callbacks.
+  std::vector<std::pair<NotifySessionCallback, ErrorCallback>>
+      start_notify_session_callbacks_;
+
+  // Flag indicates if GATT event registration is in progress.
+  bool gatt_event_registeration_in_progress_;
+
+  // GATT event handle returned by GattEventRegistrationCallback.
+  PVOID gatt_event_handle_;
+
   base::WeakPtrFactory<BluetoothRemoteGattCharacteristicWin> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(BluetoothRemoteGattCharacteristicWin);
 };
 
 }  // namespace device
 
 #endif  // DEVICE_BLUETOOTH_BLUETOOTH_REMOTE_GATT_CHARACTERISTIC_WIN_H_