Implement BluetoothRemoteGattCharacteristicWin::StartNotifySession and related unit tests

device/bluetooth/bluetooth_device_win.cc

Index: device/bluetooth/bluetooth_device_win.cc
diff --git a/device/bluetooth/bluetooth_device_win.cc b/device/bluetooth/bluetooth_device_win.cc
index 561b5a7c6532bb92298f355d70b32c07ca0dec53..d6326acca773f9cebeddccbdd201ed662743757a 100644
--- a/device/bluetooth/bluetooth_device_win.cc
+++ b/device/bluetooth/bluetooth_device_win.cc
@@ -43,6 +43,15 @@ BluetoothDeviceWin::BluetoothDeviceWin(
 }
 
 BluetoothDeviceWin::~BluetoothDeviceWin() {
+  // Explicitly take and erase GATT services one by one to ensure that calling

[ortuno, 2016/03/30 22:34:23]

This seems unrelated to this change. Why are you doing it now? Please keep
unrelated changes in separate CLs.

[gogerald1, 2016/03/31 17:44:12]

This is a related change, otherwise GetGattService in GattServiceRemoved in the
unit test will return true, default release does not set the scoped_ptr to null
first (take the scoped_ptr).

[ortuno, 2016/03/31 18:09:19]

It still seems a bug not related to the feature you are implementing. OK to
leave now, but in the feature if you find a bug while on another patch, the best
thing to do is to submit a separate patch. Otherwise someone looking at git
blame will have no idea why you added that piece of code in this seemingly
unrelated feature.

[gogerald1, 2016/04/04 23:34:00]

Acknowledged.

+  // GetGattService on removed service in GattServiceRemoved return null.

[ortuno, 2016/03/30 22:34:23]

s/return/returns/

[gogerald1, 2016/03/31 17:44:12]

Done.

+  std::vector<std::string> service_keys;
+  for (const auto& gatt_service : gatt_services_) {
+    service_keys.push_back(gatt_service.first);
+  }
+  for (const auto& key : service_keys) {
+    gatt_services_.take_and_erase(key);
+  }
 }
 
 uint32_t BluetoothDeviceWin::GetBluetoothClass() const {