Implement BluetoothRemoteGattCharacteristicWin::StartNotifySession and related unit tests

device/bluetooth/bluetooth_device_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_device_win.h"
 
 #include <string>
 
 #include "base/containers/scoped_ptr_hash_map.h"
 #include "base/logging.h"
@@ skipping 25 matching lines @@
     const net::NetLog::Source& net_log_source)
     : BluetoothDevice(adapter),
       ui_task_runner_(ui_task_runner),
       socket_thread_(socket_thread),
       net_log_(net_log),
       net_log_source_(net_log_source) {
   Update(device_state);
 }
 
 BluetoothDeviceWin::~BluetoothDeviceWin() {
+  // Explicitly take and erase GATT services one by one to ensure that calling

[ortuno, 2016/03/30 22:34:23]

This seems unrelated to this change. Why are you doing it now? Please keep
unrelated changes in separate CLs.

[gogerald1, 2016/03/31 17:44:12]

This is a related change, otherwise GetGattService in GattServiceRemoved in the
unit test will return true, default release does not set the scoped_ptr to null
first (take the scoped_ptr).

[ortuno, 2016/03/31 18:09:19]

It still seems a bug not related to the feature you are implementing. OK to
leave now, but in the feature if you find a bug while on another patch, the best
thing to do is to submit a separate patch. Otherwise someone looking at git
blame will have no idea why you added that piece of code in this seemingly
unrelated feature.

[gogerald1, 2016/04/04 23:34:00]

Acknowledged.

+  // GetGattService on removed service in GattServiceRemoved return null.

[ortuno, 2016/03/30 22:34:23]

s/return/returns/

[gogerald1, 2016/03/31 17:44:12]

Done.

+  std::vector<std::string> service_keys;
+  for (const auto& gatt_service : gatt_services_) {
+    service_keys.push_back(gatt_service.first);
+  }
+  for (const auto& key : service_keys) {
+    gatt_services_.take_and_erase(key);
+  }
 }
 
 uint32_t BluetoothDeviceWin::GetBluetoothClass() const {
   return bluetooth_class_;
 }
 
 std::string BluetoothDeviceWin::GetAddress() const {
   return address_;
 }
 
@@ skipping 326 matching lines @@
       gatt_services_.add(primary_service->GetIdentifier(),
                          scoped_ptr<BluetoothGattService>(primary_service));
       adapter_->NotifyGattServiceAdded(primary_service);
     }
   }
 
   adapter_->NotifyGattServicesDiscovered(this);
 }
 
 }  // namespace device