Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1749263002: MIPS: Improve Lsa/Dlsa implementations. (Closed)

Created:
4 years, 9 months ago by balazs.kilvady
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Improve Lsa/Dlsa implementations. Make the low level assembler implementation exact and protected to disallow explicit usage. BUG= Committed: https://crrev.com/04a735c7e74b2554a9a6f863ce289bce9f637357 Cr-Commit-Position: refs/heads/master@{#34673}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -95 lines) Patch
M src/mips/assembler-mips.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
balazs.kilvady
4 years, 9 months ago (2016-03-01 18:14:30 UTC) #2
ivica.bogosavljevic
lgtm
4 years, 9 months ago (2016-03-04 16:32:37 UTC) #3
Alan Li
lgtm
4 years, 9 months ago (2016-03-09 22:47:34 UTC) #4
Alan Li
lgtm
4 years, 9 months ago (2016-03-10 01:19:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749263002/20001
4 years, 9 months ago (2016-03-10 13:21:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 13:40:01 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 13:41:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04a735c7e74b2554a9a6f863ce289bce9f637357
Cr-Commit-Position: refs/heads/master@{#34673}

Powered by Google App Engine
This is Rietveld 408576698