Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

Issue 1749233003: [Offline pages] Making sure http:// scheme is stripped from OIB (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing CR feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
index dc634fe47d3364d36e8b8c58e342d6c6585da6c4..864489e0eaed995848f2e66a31708dc924f5d833 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
@@ -46,6 +46,7 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.ContentSettingsType;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.offlinepages.OfflinePageItem;
+import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
import org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizer;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.preferences.Preferences;
@@ -910,10 +911,8 @@ public class WebsiteSettingsPopup implements OnClickListener {
Date creationDate = new Date(item.getCreationTimeMs());
DateFormat df = DateFormat.getDateInstance(DateFormat.MEDIUM);
offlinePageCreationDate = df.format(creationDate);
- offlinePageOriginalUrl = tab.getOfflinePageOriginalUrl();
- if (offlinePageOriginalUrl.startsWith("https://")) {
- offlinePageOriginalUrl = offlinePageOriginalUrl.substring(8);
- }
+ offlinePageOriginalUrl = OfflinePageUtils.stripSchemeFromOnlineUrl(
+ tab.getOfflinePageOriginalUrl());
}
offlinePageBridge.destroy();
}

Powered by Google App Engine
This is Rietveld 408576698