CORS-RFC1918: Teach ResourceRequest about "external" requests

third_party/WebKit/Source/platform/network/ResourceRequest.h

Index: third_party/WebKit/Source/platform/network/ResourceRequest.h
diff --git a/third_party/WebKit/Source/platform/network/ResourceRequest.h b/third_party/WebKit/Source/platform/network/ResourceRequest.h
index ffab6da884fc88cdbf9e8d97b01041dda568820f..811be6ba435515821ce9003ff24b43a0dc663697 100644
--- a/third_party/WebKit/Source/platform/network/ResourceRequest.h
+++ b/third_party/WebKit/Source/platform/network/ResourceRequest.h
@@ -41,6 +41,8 @@
 
 namespace blink {
 
+class SecurityContext;
+
 enum ResourceRequestCachePolicy {
     UseProtocolCachePolicy, // normal load
     ReloadIgnoringCacheData, // reload
@@ -238,8 +240,9 @@ public:
     double uiStartTime() const { return m_uiStartTime; }
     void setUIStartTime(double uiStartTime) { m_uiStartTime = uiStartTime; }
 
-    bool originatesFromReservedIPRange() const { return m_originatesFromReservedIPRange; }
-    void setOriginatesFromReservedIPRange(bool value) { m_originatesFromReservedIPRange = value; }
+    // https://mikewest.github.io/cors-rfc1918/#external-request
+    bool isExternalRequest() const { return m_isExternalRequest; }
+    void setIsExternalRequest(bool contextHostedInReservedIPRange);

[jochen (gone - plz use gerrit), 2016/03/01 15:42:29]

if I read setIsExternalRequest(true) somewhere in the source, I'd expect that it
marks this request as external.

maybe this should be called something like
markRequestAsExternalDependingOnRequestContext and take an enum arg
(ContextIsPublicInternet, ContextIsPrivateInternet, ContextIsLocalhost)?

[Mike West, 2016/03/02 08:50:03]

Yup. Completely reworked this as an AddressSpace enum on WebURLRequest. WDYT?

 
     InputToLoadPerfMetricReportPolicy inputPerfMetricReportPolicy() const { return m_inputPerfMetricReportPolicy; }
     void setInputPerfMetricReportPolicy(InputToLoadPerfMetricReportPolicy inputPerfMetricReportPolicy) { m_inputPerfMetricReportPolicy = inputPerfMetricReportPolicy; }
@@ -284,7 +287,7 @@ private:
     bool m_didSetHTTPReferrer;
     bool m_checkForBrowserSideNavigation;
     double m_uiStartTime;
-    bool m_originatesFromReservedIPRange;
+    bool m_isExternalRequest;
     InputToLoadPerfMetricReportPolicy m_inputPerfMetricReportPolicy;
 
     mutable CacheControlHeader m_cacheControlHeaderCache;
@@ -335,7 +338,7 @@ public:
     bool m_didSetHTTPReferrer;
     bool m_checkForBrowserSideNavigation;
     double m_uiStartTime;
-    bool m_originatesFromReservedIPRange;
+    bool m_isExternalRequest;
     InputToLoadPerfMetricReportPolicy m_inputPerfMetricReportPolicy;
     bool m_followedRedirect;
 };