DevTools: Initial implementation of line-level CPU profile.

DevTools: Initial implementation of line-level CPU profile.

The JS CPU profile is available when there's a recorded timeline with a JS profile.
It is put behind an experiment.

Things to do:
  - support source maps.
  - make it possible to hide profile without reseting timeline.

BUG=590936
Committed: https://crrev.com/18c02c057c1d9d9938341fb2f4dcad2a3aef9acc
Cr-Commit-Position: refs/heads/master@{#380873}

[alph, 2016-03-01 01:34:19]

alph@chromium.org changed reviewers:
+ lushnikov@chromium.org, pfeldman@chromium.org

[pbakaus, 2016-03-01 18:48:52]

On 2016/03/01 at 01:34:19, alph wrote:
> 

You are my hero.

[alph, 2016-03-02 01:29:58]

ptal

[lushnikov, 2016-03-02 03:19:13]

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1127:
this._codeMirror.setOption("gutters", ["CodeMirror-linenumbers",
"CodeMirror-profile-info"]);
isn't refresh needed here as well?

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1131:
testElement.style.backgroundColor = `rgba(255, 0, 0, ${intensity.toFixed(3)})`;
yay, fancy strings!

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:344:
var intensity = Number.constrain(Math.log10(1 + 2 * time) / 5, 0.02, 1);
A thought: maybe consider intensity relative to the Max and Min values of the
whole profileInfo?

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js
(right):

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js:510:
if (!node.url) continue;
new line

[alph, 2016-03-02 18:34:34]

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1127:
this._codeMirror.setOption("gutters", ["CodeMirror-linenumbers",
"CodeMirror-profile-info"]);
On 2016/03/02 03:19:12, lushnikov wrote:
> isn't refresh needed here as well?

It works without it, but I'll add one to be on the safe side.

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:344:
var intensity = Number.constrain(Math.log10(1 + 2 * time) / 5, 0.02, 1);
On 2016/03/02 03:19:13, lushnikov wrote:
> A thought: maybe consider intensity relative to the Max and Min values of the
> whole profileInfo?

I'll consider it for the next patch. Not sure though if it's better to have the
color depend on the relative time rather the absolute.

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js
(right):

https://codereview.chromium.org/1748993002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js:510:
if (!node.url) continue;
On 2016/03/02 03:19:13, lushnikov wrote:
> new line

Done.

[pfeldman, 2016-03-02 19:48:59]

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:117:
Runtime.experiments.register("lineLevelProfile", "Source line level CPU
profiles");
Lets launch this without experiment.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1123:
addLineMarker: function(lineNumber, element)
You don't need this.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1133:
removeAllLineMarkers: function()
ditto. it'll become one of the decorators. you can define base decorators in the
UISourceCodeFrame.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:337:
this._textEditor.removeAllLineMarkers();
Should we make this granular?

then you would go over the WebInspector.UISourceCodeFrame.Decorator extensions,
filter them by the granular decoration type and invoke it with the code mirror
in hand.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js:532:
uiSourceCode.addLineMarker(line, decorator);
addLineMarker(line, "performance", fileInfo[1]);

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:710:
WebInspector.TimelineJSProfileProcessor.resetLineLevelProfiles();
Lets split this change?

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:76:
LineMarkersChanged: "LineMarkersChanged"
MarkersChanged

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:654:
addLineMarker: function(lineNumber, decorator)
Decorator is from the UI world, while the marker is from the SDK world. You
should only add model-level marker info here:

addLineMarker: function(lineNumber, typeString, opaqueMarkerObject);

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:657:
this._lineMarkers = [];
Bucket by type?

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:659:
this._lineMarkers.push(marker);
There should be a way to fetch markers by type.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:666:
this.dispatchEventToListeners(WebInspector.UISourceCode.Events.LineMarkersChanged);
pass  typeString as the data so that you were not waking unrelated modules.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:670:
removeAllLineMarkers: function()
There should be a way to clear all "message" markers or all "performance"
markers (by category.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:918:
WebInspector.UISourceCode.LineMarker = function(line, decorator)
You will only have line and opaque object here, no methods required.

[alph, 2016-03-03 02:02:52]

ptal

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:117:
Runtime.experiments.register("lineLevelProfile", "Source line level CPU
profiles");
On 2016/03/02 19:48:58, pfeldman wrote:
> Lets launch this without experiment.

Done.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1123:
addLineMarker: function(lineNumber, element)
On 2016/03/02 19:48:59, pfeldman wrote:
> You don't need this.

I need a plumbing from UISourceCodeFrame to CM.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1133:
removeAllLineMarkers: function()
On 2016/03/02 19:48:59, pfeldman wrote:
> ditto. it'll become one of the decorators. you can define base decorators in
the
> UISourceCodeFrame.

ditto

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:337:
this._textEditor.removeAllLineMarkers();
On 2016/03/02 19:48:59, pfeldman wrote:
> Should we make this granular?
> 
> then you would go over the WebInspector.UISourceCodeFrame.Decorator
extensions,
> filter them by the granular decoration type and invoke it with the code mirror
> in hand.

Done.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js:532:
uiSourceCode.addLineMarker(line, decorator);
On 2016/03/02 19:48:59, pfeldman wrote:
> addLineMarker(line, "performance", fileInfo[1]);

Done.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:710:
WebInspector.TimelineJSProfileProcessor.resetLineLevelProfiles();
On 2016/03/02 19:48:59, pfeldman wrote:
> Lets split this change?

Let me try to make it within the CL.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:76:
LineMarkersChanged: "LineMarkersChanged"
On 2016/03/02 19:48:59, pfeldman wrote:
> MarkersChanged

Acknowledged.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:654:
addLineMarker: function(lineNumber, decorator)
On 2016/03/02 19:48:59, pfeldman wrote:
> Decorator is from the UI world, while the marker is from the SDK world. You
> should only add model-level marker info here:
> 
> addLineMarker: function(lineNumber, typeString, opaqueMarkerObject);

Done.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:657:
this._lineMarkers = [];
On 2016/03/02 19:48:59, pfeldman wrote:
> Bucket by type?

Done.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:659:
this._lineMarkers.push(marker);
On 2016/03/02 19:48:59, pfeldman wrote:
> There should be a way to fetch markers by type.

Done.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:666:
this.dispatchEventToListeners(WebInspector.UISourceCode.Events.LineMarkersChanged);
On 2016/03/02 19:48:59, pfeldman wrote:
> pass  typeString as the data so that you were not waking unrelated modules.

Done.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:670:
removeAllLineMarkers: function()
On 2016/03/02 19:48:59, pfeldman wrote:
> There should be a way to clear all "message" markers or all "performance"
> markers (by category.

Done.

https://codereview.chromium.org/1748993002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:918:
WebInspector.UISourceCode.LineMarker = function(line, decorator)
On 2016/03/02 19:48:59, pfeldman wrote:
> You will only have line and opaque object here, no methods required.

Done.

[pfeldman, 2016-03-03 02:38:42]

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:600:
WebInspector.UISourceCodeFrame._lineMarkerDecorator._decorators.set("performance",
new WebInspector.UISourceCodeFrame.PerformanceDecorator());
this should move to the profiler module.

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:681:
lineMarkers: function()
Lets return them by type - that's the way decorators will be querying them.

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:949: *
@return {?}
*

[alph, 2016-03-05 00:37:09]

ptal

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:600:
WebInspector.UISourceCodeFrame._lineMarkerDecorator._decorators.set("performance",
new WebInspector.UISourceCodeFrame.PerformanceDecorator());
On 2016/03/03 02:38:42, pfeldman wrote:
> this should move to the profiler module.

Done.

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:681:
lineMarkers: function()
On 2016/03/03 02:38:42, pfeldman wrote:
> Lets return them by type - that's the way decorators will be querying them.

Done.

https://codereview.chromium.org/1748993002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:949: *
@return {?}
On 2016/03/03 02:38:42, pfeldman wrote:
> *

Done.

[pfeldman, 2016-03-07 19:57:50]

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1141:
this._codeMirror.setGutterMarker(lineNumber, "CodeMirror-linemarkers-" + type,
element);
Throttle using operation?

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css:11:
width: 74px;
4 space indent?

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css:283:
text-align: right;
ditto

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:123:
this._populateLineMarkers();
_decorateLineMarkers?

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:342:
this._decorateLineMarker(marker);
Didn't you want to throttle these in a single CM operation?

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:360:
_decorateLineMarker: function(marker)
JSDocs are missing.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:365:
_lineMarkerDecorator: function(type)
ditto

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:367:
return self.runtime.instancePromise("line-marker-decorator-" + type);
Decorator should be named after interface it implements.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:2105:
WebInspector.TimelineUIUtils.PerformanceLineMarkerDecorator = function()
Should implement something.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:671:
removeAllLineMarkers: function(type)
removeLineMarkers (not all)

[alph, 2016-03-08 00:57:43]

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:1141:
this._codeMirror.setGutterMarker(lineNumber, "CodeMirror-linemarkers-" + type,
element);
On 2016/03/07 19:57:50, pfeldman wrote:
> Throttle using operation?

It's already wrapped inside CM.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css:11:
width: 74px;
On 2016/03/07 19:57:50, pfeldman wrote:
> 4 space indent?

Done.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css:283:
text-align: right;
On 2016/03/07 19:57:50, pfeldman wrote:
> ditto

Done.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:123:
this._populateLineMarkers();
On 2016/03/07 19:57:50, pfeldman wrote:
> _decorateLineMarkers?

Done.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:342:
this._decorateLineMarker(marker);
On 2016/03/07 19:57:50, pfeldman wrote:
> Didn't you want to throttle these in a single CM operation?

Done.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:360:
_decorateLineMarker: function(marker)
On 2016/03/07 19:57:50, pfeldman wrote:
> JSDocs are missing.

Done.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:365:
_lineMarkerDecorator: function(type)
On 2016/03/07 19:57:50, pfeldman wrote:
> ditto

Done.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:367:
return self.runtime.instancePromise("line-marker-decorator-" + type);
On 2016/03/07 19:57:50, pfeldman wrote:
> Decorator should be named after interface it implements.

Done.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:2105:
WebInspector.TimelineUIUtils.PerformanceLineMarkerDecorator = function()
On 2016/03/07 19:57:50, pfeldman wrote:
> Should implement something.

Done.

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1748993002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:671:
removeAllLineMarkers: function(type)
On 2016/03/07 19:57:50, pfeldman wrote:
> removeLineMarkers (not all)

I don't need this API. Let's add it when we see there's a need for it.

[pfeldman, 2016-03-09 02:15:01]

this requires a test.

[alph, 2016-03-10 18:45:16]

On 2016/03/09 02:15:01, pfeldman wrote:
> this requires a test.

done. ptal

[pfeldman, 2016-03-11 22:42:02]

lgtm

[caseq, 2016-03-11 22:52:04]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-03-11 22:52:06]

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js
(right):

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js:531:
var text = WebInspector.UIString("%.1f\xa0ms", time);
Can we get UI stuff out of model classes?

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js:537:
uiSourceCode.addLineDecoration(line, "performance", object);
ditto.

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js
(right):

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js:733: var
jsProfileModel = new WebInspector.CPUProfileDataModel(cpuProfile);
Can we take it out of model?

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:2121:
var type = "performance";
nit: decoratorType. Also, consider @const.

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:2123:
textEditor.operation(() => {
nit: extract named function?

[alph, 2016-03-12 00:47:54]

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js
(right):

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js:531:
var text = WebInspector.UIString("%.1f\xa0ms", time);
On 2016/03/11 22:52:05, caseq wrote:
> Can we get UI stuff out of model classes?

Done.

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js:537:
uiSourceCode.addLineDecoration(line, "performance", object);
On 2016/03/11 22:52:05, caseq wrote:
> ditto.

Done.

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js
(right):

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js:733: var
jsProfileModel = new WebInspector.CPUProfileDataModel(cpuProfile);
On 2016/03/11 22:52:05, caseq wrote:
> Can we take it out of model?

Done.

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js
(right):

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:2121:
var type = "performance";
On 2016/03/11 22:52:06, caseq wrote:
> nit: decoratorType. Also, consider @const.

Done.

https://codereview.chromium.org/1748993002/diff/220001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:2123:
textEditor.operation(() => {
On 2016/03/11 22:52:05, caseq wrote:
> nit: extract named function?

Done.

[caseq, 2016-03-12 00:58:15]

lgtm

[alph, 2016-03-12 01:05:16]

The CQ bit was checked by alph@chromium.org

[alph, 2016-03-12 01:05:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1748993002/#ps240001
(title: "addressing comments.")

[commit-bot: I haz the power, 2016-03-12 01:05:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748993002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748993002/240001

[commit-bot: I haz the power, 2016-03-12 03:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 03:19:47]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[alph, 2016-03-12 08:31:21]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-03-12 08:31:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1748993002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1748993002/240001

[commit-bot: I haz the power, 2016-03-12 10:06:54]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-03-12 10:08:22]

Description was changed from

==========
DevTools: Initial implementation of line-level CPU profile.

The JS CPU profile is available when there's a recorded timeline with a JS
profile.
It is put behind an experiment.

Things to do:
  - support source maps.
  - make it possible to hide profile without reseting timeline.

BUG=590936
==========

to

==========
DevTools: Initial implementation of line-level CPU profile.

The JS CPU profile is available when there's a recorded timeline with a JS
profile.
It is put behind an experiment.

Things to do:
  - support source maps.
  - make it possible to hide profile without reseting timeline.

BUG=590936

Committed: https://crrev.com/18c02c057c1d9d9938341fb2f4dcad2a3aef9acc
Cr-Commit-Position: refs/heads/master@{#380873}
==========

[commit-bot: I haz the power, 2016-03-12 10:08:23]

Patchset 13 (id:??) landed as
https://crrev.com/18c02c057c1d9d9938341fb2f4dcad2a3aef9acc
Cr-Commit-Position: refs/heads/master@{#380873}