third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js - Issue 1748993002: DevTools: Initial implementation of line-level CPU profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js

Issue 1748993002: DevTools: Initial implementation of line-level CPU profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/source_frame/cmdevtools.css ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js

index ea1e23a3123759c3492dfe581a30c41828784ed1..d9e825be2851e2ab068367cf2bb7d5eb4b7774dc 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineJSProfile.js

@@ -6,15 +6,12 @@

WebInspector.TimelineJSProfileProcessor = { };

/**

- * @param {!ProfilerAgent.CPUProfile} jsProfile

+ * @param {!WebInspector.CPUProfileDataModel} jsProfileModel

* @param {!WebInspector.TracingModel.Thread} thread

* @return {!Array<!WebInspector.TracingModel.Event>}

-WebInspector.TimelineJSProfileProcessor.generateTracingEventsFromCpuProfile = function(jsProfile, thread)

+WebInspector.TimelineJSProfileProcessor.generateTracingEventsFromCpuProfile = function(jsProfileModel, thread)

{

- if (!jsProfile.samples)

- return [];

- var jsProfileModel = new WebInspector.CPUProfileDataModel(jsProfile);

var idleNode = jsProfileModel.idleNode;

var programNode = jsProfileModel.programNode;

var gcNode = jsProfileModel.gcNode;