Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1748973003: Revert of Bootstrap Mojo IPC independent of Chrome IPC (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, Mark Dittmer, nasko+codewatch_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, rickyz+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, Mark Seaborn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bootstrap Mojo IPC independent of Chrome IPC (patchset #18 id:340001 of https://codereview.chromium.org/1685183004/ ) Reason for revert: Breaking NaCl in a way that somehow was not caught in the CQ... :{ Will reland once that's sorted out. Original issue's description: > Bootstrap Mojo IPC independent of Chrome IPC > > This initializes Mojo IPC very early in child process > startup so we can start using cross-process pipes in > content without a dependency on Chrome IPC. > > On all supported platforms, a new OS pipe handle is > passed through ChildProcessLauncher and hooked up to > the EDK on ChildThreadImpl startup to establish a > Mojo IPC channel to the parent. > > A command-line argument is also to used to share a > unique pipe token with the child, and this token is > exchanged over the Mojo IPC channel to bootstrap a > primordial message pipe. > > While this CL establishes these facilities in a way > that can be used for all child processes, only > render processes are brought up in this way for now. > > BUG=583557 > TEST=Chrome still runs in mash with Mus-in-renderer support. > > Committed: https://crrev.com/eb199fbaecd8e5d294010dfbe8897b7d83aeab07 > Cr-Commit-Position: refs/heads/master@{#378272} TBR=ben@chromium.org,jam@chromium.org,jschuh@chromium.org,pennymac@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583557 Committed: https://crrev.com/42b78f983bb44e67a6d45f97dd7ecc8f6476486d Cr-Commit-Position: refs/heads/master@{#378373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -142 lines) Patch
M content/app/content_main_runner.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/child_process_launcher.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/browser/child_process_launcher.cc View 12 chunks +5 lines, -34 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.h View 1 chunk +7 lines, -9 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 7 chunks +62 lines, -19 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +14 lines, -6 lines 0 comments Download
M content/child/child_thread_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 6 chunks +26 lines, -33 lines 0 comments Download
M content/common/mojo/mojo_messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/zygote_fork_delegate_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ipc/ipc_descriptors.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/embedder/platform_channel_pair.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/node_controller.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of Bootstrap Mojo IPC independent of Chrome IPC
4 years, 9 months ago (2016-03-01 02:22:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748973003/1
4 years, 9 months ago (2016-03-01 02:23:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 02:24:11 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 02:25:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42b78f983bb44e67a6d45f97dd7ecc8f6476486d
Cr-Commit-Position: refs/heads/master@{#378373}

Powered by Google App Engine
This is Rietveld 408576698