Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1748883005: Add mobile version of v8.infinite_scroll benchmark. (Closed)

Created:
4 years, 9 months ago by ulan
Modified:
4 years, 9 months ago
Reviewers:
eakuefner
CC:
chromium-reviews, Hannes Payer (out of office), jochen (gone - plz use gerrit), telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mobile version of v8.infinite_scroll benchmark. BUG=591061 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/26d97f31aee6f9f3fa6725fe4c9b9ddcd1abe173 Cr-Commit-Position: refs/heads/master@{#380582}

Patch Set 1 #

Patch Set 2 : Merge with cl 1754173002 and address Ethan's comments #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : add missing hash file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -33 lines) Patch
M tools/perf/benchmarks/v8.py View 1 2 3 4 chunks +34 lines, -14 lines 0 comments Download
M tools/perf/page_sets/data/credentials.json.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
A + tools/perf/page_sets/data/mobile_infinite_scroll.json View 1 chunk +6 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/mobile_infinite_scroll_000.wpr.sha1 View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/login_helpers/login_utils.py View 1 2 chunks +23 lines, -4 lines 0 comments Download
A + tools/perf/page_sets/login_helpers/mobile_facebook_login.py View 1 2 chunks +12 lines, -12 lines 0 comments Download
A tools/perf/page_sets/mobile_facebook_page.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
A tools/perf/page_sets/mobile_infinite_scroll_cases.py View 1 2 3 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
ulan
PTAL. This CL depends on 1754173002
4 years, 9 months ago (2016-03-02 14:53:56 UTC) #3
ulan
New patch set includes the mobile facebook page from 1754173002 with addressed comments. PTAL.
4 years, 9 months ago (2016-03-04 10:06:16 UTC) #5
ulan
Gentle ping. Ethan, I am sorry to bother, just making sure that the CL didn't ...
4 years, 9 months ago (2016-03-09 17:21:43 UTC) #6
eakuefner
lgtm % some nits https://codereview.chromium.org/1748883005/diff/40001/tools/perf/benchmarks/v8.py File tools/perf/benchmarks/v8.py (right): https://codereview.chromium.org/1748883005/diff/40001/tools/perf/benchmarks/v8.py#newcode126 tools/perf/benchmarks/v8.py:126: def ValueCanBeAddedPredicate(cls, value, is_first): You ...
4 years, 9 months ago (2016-03-09 17:49:08 UTC) #7
ulan
Thanks! https://codereview.chromium.org/1748883005/diff/40001/tools/perf/benchmarks/v8.py File tools/perf/benchmarks/v8.py (right): https://codereview.chromium.org/1748883005/diff/40001/tools/perf/benchmarks/v8.py#newcode126 tools/perf/benchmarks/v8.py:126: def ValueCanBeAddedPredicate(cls, value, is_first): On 2016/03/09 17:49:08, eakuefner ...
4 years, 9 months ago (2016-03-10 11:41:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748883005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748883005/40001
4 years, 9 months ago (2016-03-10 11:41:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/builds/31)
4 years, 9 months ago (2016-03-10 13:35:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748883005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748883005/60001
4 years, 9 months ago (2016-03-10 14:29:44 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/40)
4 years, 9 months ago (2016-03-10 16:55:25 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748883005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748883005/80001
4 years, 9 months ago (2016-03-10 17:11:35 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-10 19:13:02 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748883005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748883005/80001
4 years, 9 months ago (2016-03-11 08:52:08 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-11 08:58:03 UTC) #26
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 08:59:40 UTC) #28
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/26d97f31aee6f9f3fa6725fe4c9b9ddcd1abe173
Cr-Commit-Position: refs/heads/master@{#380582}

Powered by Google App Engine
This is Rietveld 408576698