Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: tools/perf/page_sets/login_helpers/login_utils.py

Issue 1748883005: Add mobile version of v8.infinite_scroll benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing hash file Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/login_helpers/login_utils.py
diff --git a/tools/perf/page_sets/login_helpers/login_utils.py b/tools/perf/page_sets/login_helpers/login_utils.py
index a58a64caea2b55396ffb7653e1abf4e7b70f4e35..5e9bbe0708b943af5e953ac9220117fe96706143 100644
--- a/tools/perf/page_sets/login_helpers/login_utils.py
+++ b/tools/perf/page_sets/login_helpers/login_utils.py
@@ -27,6 +27,27 @@ def GetAccountNameAndPassword(credential,
c = credentials.get(credential)
return c['username'], c['password']
+def InputWithSelector(action_runner, input_text, input_selector):
+ """Sets the text value of an input field in a form on the page.
+
+ Waits until the input element exists on the page. Then executes JS to populate
+ the value property of the element with |input_text|.
+
+ Args:
+ action_runner: ActionRunner instance to execute JS to populate form fields.
+ input_text: Text string to populate the input field with.
+ input_selector: The selector of the input element.
+
+
+ Raises:
+ exceptions.TimeoutException: If waiting to find the element times out.
+ exceptions.Error: See ExecuteJavaScript() for a detailed list of
+ possible exceptions.
+ """
+ action_runner.WaitForElement(selector=input_selector)
+ action_runner.ExecuteJavaScript(
+ 'document.querySelector("%s").value = "%s";' %
+ (input_selector, input_text))
def InputForm(action_runner, input_text, input_id, form_id=None):
"""Sets the text value of an input field in a form on the page.
@@ -51,7 +72,5 @@ def InputForm(action_runner, input_text, input_id, form_id=None):
element_selector = '#%s' % (input_id)
else:
raise ValueError("Input ID can not be None or empty.")
- action_runner.WaitForElement(selector=element_selector)
- action_runner.ExecuteJavaScript(
- 'document.querySelector("%s").value = "%s";' %
- (element_selector, input_text))
+ InputWithSelector(action_runner, input_text, element_selector)
+

Powered by Google App Engine
This is Rietveld 408576698