Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1748723002:
Do not add Resource for SubstituteData to MemoryCache (Closed)
|
Created:
4 years, 9 months ago by hiroshige Modified:
4 years, 9 months ago Reviewers:
Nate Chapin CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin Base URL:
https://chromium.googlesource.com/chromium/src.git@SVG_0_preCacheData Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not add Resource for SubstituteData to MemoryCache
BUG=591079
Committed: https://crrev.com/f091cedd80474f519bb925f1dd0e828efe03bd37
Cr-Commit-Position: refs/heads/master@{#380040}
Patch Set 1 #Patch Set 2 : #
Total comments: 2
Patch Set 3 : Remove special case for substitute data in MemoryCache::prune() #
Depends on Patchset: Messages
Total messages: 25 (12 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748723002/1
Description was changed from ========== Do not add Resource for SubstituteData to MemoryCache BUG= ========== to ========== Do not add Resource for SubstituteData to MemoryCache BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748723002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Do not add Resource for SubstituteData to MemoryCache BUG= ========== to ========== Do not add Resource for SubstituteData to MemoryCache BUG=591079 ==========
hiroshige@chromium.org changed reviewers: + japhet@chromium.org
PTAL. (this is not needed in the context of SVG issues but I think good for loader cleanup)
https://codereview.chromium.org/1748723002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/1748723002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:355: memoryCache()->add(resource.get()); There is a special case related to substitue data in MemoryCache::prune. We should probably delete that if SubstituteData will never be in the cache.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748723002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1748723002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/1748723002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:355: memoryCache()->add(resource.get()); On 2016/03/01 17:51:42, Nate Chapin wrote: > There is a special case related to substitue data in MemoryCache::prune. We > should probably delete that if SubstituteData will never be in the cache. Done.
lgtm
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1748723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1748723002/40001
Message was sent while issue was closed.
Description was changed from ========== Do not add Resource for SubstituteData to MemoryCache BUG=591079 ========== to ========== Do not add Resource for SubstituteData to MemoryCache BUG=591079 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Do not add Resource for SubstituteData to MemoryCache BUG=591079 ========== to ========== Do not add Resource for SubstituteData to MemoryCache BUG=591079 Committed: https://crrev.com/f091cedd80474f519bb925f1dd0e828efe03bd37 Cr-Commit-Position: refs/heads/master@{#380040} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f091cedd80474f519bb925f1dd0e828efe03bd37 Cr-Commit-Position: refs/heads/master@{#380040} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
