Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1747833003:
Make ResourceFetcher not to rely on MemoryCache to serve static data (Closed)
|
Created:
4 years, 9 months ago by hiroshige Modified:
4 years, 9 months ago Reviewers:
Nate Chapin CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake ResourceFetcher not to rely on MemoryCache to serve static data
Previously, Resource for static data (data URLs or SubstituteData) are created
and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked
up from MemoryCache.
This CL passes Resource created there as the return value, not via MemoryCache.
This CL also renames preCacheData() to resourceForStaticData().
This CL doesn't change the behavior because resourceForStaticData() still
always adds newly created Resource to MemoryCache.
BUG=591079, 382170
Committed: https://crrev.com/7fdc1e4512c4aeeb39415656da42fbc67d2a94e6
Cr-Commit-Position: refs/heads/master@{#378483}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Dependent Patchsets: Messages
Total messages: 24 (13 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747833003/1
Description was changed from ========== Do not rely on MemoryCache to serve data URLs/SubstituteData [1/2] Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData() because it will no longer always put Resource to MemoryCache in subsequent CLs. BUG= ========== to ========== Do not rely on MemoryCache to serve data URLs/SubstituteData Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL renames preCacheData() to resourceForStaticData(), and passes Resource created there as the return value, not via MemoryCache. This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747833003/20001
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747833003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
Description was changed from ========== Do not rely on MemoryCache to serve data URLs/SubstituteData Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL renames preCacheData() to resourceForStaticData(), and passes Resource created there as the return value, not via MemoryCache. This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG= ========== to ========== Do not rely on MemoryCache to serve data URLs/SubstituteData Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079 ==========
hiroshige@chromium.org changed reviewers: + japhet@chromium.org
PTAL.
Description was changed from ========== Do not rely on MemoryCache to serve data URLs/SubstituteData Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079 ========== to ========== Do not rely on MemoryCache to serve data URLs/SubstituteData Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079, 382170 ==========
lgtm
Description was changed from ========== Do not rely on MemoryCache to serve data URLs/SubstituteData Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079, 382170 ========== to ========== Make ResourceFetcher not to rely on MemoryCache to serve static data Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079, 382170 ==========
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747833003/40001
Message was sent while issue was closed.
Description was changed from ========== Make ResourceFetcher not to rely on MemoryCache to serve static data Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079, 382170 ========== to ========== Make ResourceFetcher not to rely on MemoryCache to serve static data Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079, 382170 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Make ResourceFetcher not to rely on MemoryCache to serve static data Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079, 382170 ========== to ========== Make ResourceFetcher not to rely on MemoryCache to serve static data Previously, Resource for static data (data URLs or SubstituteData) are created and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked up from MemoryCache. This CL passes Resource created there as the return value, not via MemoryCache. This CL also renames preCacheData() to resourceForStaticData(). This CL doesn't change the behavior because resourceForStaticData() still always adds newly created Resource to MemoryCache. BUG=591079, 382170 Committed: https://crrev.com/7fdc1e4512c4aeeb39415656da42fbc67d2a94e6 Cr-Commit-Position: refs/heads/master@{#378483} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7fdc1e4512c4aeeb39415656da42fbc67d2a94e6 Cr-Commit-Position: refs/heads/master@{#378483} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
