content/browser/renderer_host/render_widget_host_impl.h - Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture

Patch Set: Addressing reviewer comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_delegate.h ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.h

diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h

index 3c2ead0dbbb75a064e3dc0ad598c21e4e78bb150..b2dc052be2d35ceaa0a8f6d0d93e3d07cee2dcf1 100644

--- a/content/browser/renderer_host/render_widget_host_impl.h

+++ b/content/browser/renderer_host/render_widget_host_impl.h

@@ -831,12 +831,6 @@ class CONTENT_EXPORT RenderWidgetHostImpl : public RenderWidgetHost,

// renderer process before clearing any previously displayed content.

base::TimeDelta new_content_rendering_delay_;

- // Timer used to batch together mouse wheel events for the delegate

- // OnUserInteraction method. A wheel event is only dispatched when a wheel

- // event has not been seen for kMouseWheelCoalesceInterval seconds prior.

- // TODO(dominickn): remove this when GestureScrollBegin has landed.

- scoped_ptr<base::ElapsedTimer> mouse_wheel_coalesce_timer_;

base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);