content/browser/renderer_host/render_widget_host_delegate.h - Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_delegate.h

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture

Patch Set: Addressing reviewer comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/external_protocol/external_protocol_observer.cc ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_delegate.h

diff --git a/content/browser/renderer_host/render_widget_host_delegate.h b/content/browser/renderer_host/render_widget_host_delegate.h

index e562f2908270c349b2a0521ecff68f1c9f66a35b..b58801d472bf744214298ad9ccb6e945d0c6948f 100644

--- a/content/browser/renderer_host/render_widget_host_delegate.h

+++ b/content/browser/renderer_host/render_widget_host_delegate.h

@@ -78,11 +78,10 @@ class CONTENT_EXPORT RenderWidgetHostDelegate {

// the event itself.

virtual bool HandleWheelEvent(const blink::WebMouseWheelEvent& event);

- // Notification the user has performed a direct interaction (mouse down, mouse

- // wheel, raw key down, gesture tap, or browser-initiated navigation) while

+ // Notification the user has performed a direct interaction (mouse down,

+ // scroll, raw key down, gesture tap, or browser-initiated navigation) while

// focus was on the page. Informs the delegate that a user is interacting with

- // a site. Only the first mouse wheel event during a scroll will trigger this

- // method.

+ // a site.

virtual void OnUserInteraction(RenderWidgetHostImpl* render_widget_host,

const blink::WebInputEvent::Type type) {}