chrome/browser/engagement/site_engagement_service_unittest.cc - Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture

Patch Set: Addressing reviewer comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_metrics.h ('k') | chrome/browser/external_protocol/external_protocol_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_service_unittest.cc

diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc

index be3fc1e675e76173c911590f4e8668e984474f2d..44abc37d6f4fd5bece8309c4374f565ffab0b90f 100644

--- a/chrome/browser/engagement/site_engagement_service_unittest.cc

+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc

@@ -643,7 +643,7 @@ TEST_F(SiteEngagementServiceTest, GetTotalUserInputPoints) {

EXPECT_DOUBLE_EQ(0.15, service->GetScore(url1));

EXPECT_DOUBLE_EQ(0.3, service->GetTotalEngagementPoints());

- service->HandleUserInput(url2, SiteEngagementMetrics::ENGAGEMENT_WHEEL);

+ service->HandleUserInput(url2, SiteEngagementMetrics::ENGAGEMENT_SCROLL);

service->HandleUserInput(url3,

SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE);

EXPECT_DOUBLE_EQ(0.15, service->GetScore(url2));

@@ -906,7 +906,7 @@ TEST_F(SiteEngagementServiceTest, CheckHistograms) {

service->HandleNavigation(url1, ui::PAGE_TRANSITION_GENERATED);

service->HandleNavigation(url1, ui::PAGE_TRANSITION_TYPED);

- service->HandleUserInput(url2, SiteEngagementMetrics::ENGAGEMENT_WHEEL);

+ service->HandleUserInput(url2, SiteEngagementMetrics::ENGAGEMENT_SCROLL);

service->HandleUserInput(url1, SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);

service->HandleUserInput(url3, SiteEngagementMetrics::ENGAGEMENT_MOUSE);

@@ -922,7 +922,7 @@ TEST_F(SiteEngagementServiceTest, CheckHistograms) {

SiteEngagementMetrics::ENGAGEMENT_TOUCH_GESTURE,

1);

histograms.ExpectBucketCount(SiteEngagementMetrics::kEngagementTypeHistogram,

- SiteEngagementMetrics::ENGAGEMENT_WHEEL, 1);

+ SiteEngagementMetrics::ENGAGEMENT_SCROLL, 1);

histograms.ExpectBucketCount(

SiteEngagementMetrics::kEngagementTypeHistogram,

SiteEngagementMetrics::ENGAGEMENT_FIRST_DAILY_ENGAGEMENT, 3);