chrome/browser/engagement/site_engagement_metrics.h - Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_metrics.h

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture

Patch Set: Addressing reviewer comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_helper_unittest.cc ('k') | chrome/browser/engagement/site_engagement_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_metrics.h

diff --git a/chrome/browser/engagement/site_engagement_metrics.h b/chrome/browser/engagement/site_engagement_metrics.h

index 0d249e7de63eb7795ef1c00694103c10b1c750ac..1c08b7f66f0cec5a08cc3fb32a9fd20d92486cf2 100644

--- a/chrome/browser/engagement/site_engagement_metrics.h

+++ b/chrome/browser/engagement/site_engagement_metrics.h

@@ -22,7 +22,7 @@ class SiteEngagementMetrics {

ENGAGEMENT_KEYPRESS,

ENGAGEMENT_MOUSE,

ENGAGEMENT_TOUCH_GESTURE,

- ENGAGEMENT_WHEEL,

+ ENGAGEMENT_SCROLL,

ENGAGEMENT_MEDIA_HIDDEN,

ENGAGEMENT_MEDIA_VISIBLE,

ENGAGEMENT_WEBAPP_SHORTCUT_LAUNCH,