chrome/browser/external_protocol/external_protocol_observer.cc - Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/external_protocol/external_protocol_observer.cc

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_request_limiter.cc ('K') | « chrome/browser/engagement/site_engagement_service_unittest.cc ('k') | content/browser/renderer_host/render_widget_host_delegate.h » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/external_protocol/external_protocol_observer.cc

diff --git a/chrome/browser/external_protocol/external_protocol_observer.cc b/chrome/browser/external_protocol/external_protocol_observer.cc

index ec6650322db18df34edf6252f4a4f4d5a37a52f5..d6ac7a8a16e6bde3285e6ba3b18e7982f3030598 100644

--- a/chrome/browser/external_protocol/external_protocol_observer.cc

+++ b/chrome/browser/external_protocol/external_protocol_observer.cc

@@ -20,6 +20,6 @@ ExternalProtocolObserver::~ExternalProtocolObserver() {

void ExternalProtocolObserver::DidGetUserInteraction(

const blink::WebInputEvent::Type type) {

// Ignore scroll events for allowing external protocol launch.

- if (type != blink::WebInputEvent::MouseWheel)

+ if (type != blink::WebInputEvent::GestureScrollBegin)

tdresser 2016/02/29 14:14:12 This also involves a behavior change for touch, do

dominickn 2016/02/29 22:52:02 See comment for the download request limiter.

ExternalProtocolHandler::PermitLaunchUrl();

}