chrome/browser/download/download_request_limiter.cc - Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction

Unified Diff: chrome/browser/download/download_request_limiter.cc

Issue 1748553002: Replace MouseWheel events with GestureScrollBegin in WebContentsObserver::DidGetUserInteraction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-didgetusergesture

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/download/download_request_limiter_unittest.cc » ('j') | chrome/browser/external_protocol/external_protocol_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_request_limiter.cc

diff --git a/chrome/browser/download/download_request_limiter.cc b/chrome/browser/download/download_request_limiter.cc

index fbfded785e5e6e094267646358f3cc8b2ee12715..992e0a23958df40e84cc4a1a82b74e7722dcf358 100644

--- a/chrome/browser/download/download_request_limiter.cc

+++ b/chrome/browser/download/download_request_limiter.cc

@@ -99,7 +99,7 @@ void DownloadRequestLimiter::TabDownloadState::DidNavigateMainFrame(

void DownloadRequestLimiter::TabDownloadState::DidGetUserInteraction(

const blink::WebInputEvent::Type type) {

- if (is_showing_prompt() || type == blink::WebInputEvent::MouseWheel) {

+ if (is_showing_prompt() || type == blink::WebInputEvent::GestureScrollBegin) {

tdresser 2016/02/29 14:14:11 This is a behavior change for touch scrolling - wa

dominickn 2016/02/29 22:52:02 I thought this wasn't a behaviour change? The inte

tdresser 2016/03/01 15:12:10 Sorry, I missed that touch gesture events aren't b

// Don't change state if a prompt is showing or if the user has scrolled.

return;

}