Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1747873002:
docs: convert ios build instructions from html to markdown (Closed)
Descriptiondocs: convert ios build instructions from html to markdown
This patch converts iOS Build Instructions from
https://www.chromium.org/developers/how-tos/build-instructions-ios
to Markdown and check it in docs/ directory.
The process for doing this was done partially by command line tools
and partially manually after inspection at http://dillinger.io/.
The command lines to generate the markdown file were:
$ wget
https://www.chromium.org/developers/how-tos/build-instructions-ios
$ pandoc -s -r html build-instructions-ios -o ios_build_instructions.md
BUG=None
TEST=opened ios_build_instructions.md in dillinger.io and visually
inspected it.
R=sdefresne@chromium.org
Committed: https://crrev.com/b8f70688d44d033c9f14786cb19ea6b176559456
Cr-Commit-Position: refs/heads/master@{#378417}
Patch Set 1 #Patch Set 2 : rm ending lines #
Total comments: 2
Patch Set 3 : review #
Total comments: 8
Messages
Total messages: 13 (5 generated)
Description was changed from ========== docs: convert ios build instructions from html to markdown This patch converts iOS Build instructions from https://www.chromium.org/developers/how-tos/build-instructions-ios to Markdown and check it in docs/ directory. The process for doing this was done partially by command line tools and partially manually after inspection at http://dillinger.io/. The command lines to generate the markdown file were: $ wget https://www.chromium.org/developers/how-tos/build-instructions-ios $ pandoc -s -r html build-instructions-ios -o ios_build_instructions.md BUG=None TEST=opened ios_build_instructions.md in dillinger.io and visually inspected it. R=sdefresne@chromium.org ========== to ========== docs: convert ios build instructions from html to markdown This patch converts iOS Build Instructions from https://www.chromium.org/developers/how-tos/build-instructions-ios to Markdown and check it in docs/ directory. The process for doing this was done partially by command line tools and partially manually after inspection at http://dillinger.io/. The command lines to generate the markdown file were: $ wget https://www.chromium.org/developers/how-tos/build-instructions-ios $ pandoc -s -r html build-instructions-ios -o ios_build_instructions.md BUG=None TEST=opened ios_build_instructions.md in dillinger.io and visually inspected it. R=sdefresne@chromium.org ==========
lgtm https://codereview.chromium.org/1747873002/diff/20001/docs/ios_build_instruct... File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1747873002/diff/20001/docs/ios_build_instruct... docs/ios_build_instructions.md:3: **Note:** Upstreaming of iOS code is still a work in progress, and is I would just say: **Note:** Upstreaming of iOS code is still a work in progress. In particular, not that **it is not currently possible to build an actual Chromium app.** Currently, the buildable binaries are ios\_web\_shell (a minimal wrapper around the web layer), and various unit tests.
https://codereview.chromium.org/1747873002/diff/20001/docs/ios_build_instruct... File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1747873002/diff/20001/docs/ios_build_instruct... docs/ios_build_instructions.md:3: **Note:** Upstreaming of iOS code is still a work in progress, and is On 2016/02/29 15:18:07, sdefresne wrote: > I would just say: > > **Note:** Upstreaming of iOS code is still a work in progress. In particular, > not that **it is not currently possible to build an actual Chromium app.** > Currently, the buildable binaries are ios\_web\_shell (a minimal wrapper > around the web layer), and various unit tests. Done.
The CQ bit was checked by tfarina@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org Link to the patchset: https://codereview.chromium.org/1747873002/#ps40001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747873002/40001
Message was sent while issue was closed.
Description was changed from ========== docs: convert ios build instructions from html to markdown This patch converts iOS Build Instructions from https://www.chromium.org/developers/how-tos/build-instructions-ios to Markdown and check it in docs/ directory. The process for doing this was done partially by command line tools and partially manually after inspection at http://dillinger.io/. The command lines to generate the markdown file were: $ wget https://www.chromium.org/developers/how-tos/build-instructions-ios $ pandoc -s -r html build-instructions-ios -o ios_build_instructions.md BUG=None TEST=opened ios_build_instructions.md in dillinger.io and visually inspected it. R=sdefresne@chromium.org ========== to ========== docs: convert ios build instructions from html to markdown This patch converts iOS Build Instructions from https://www.chromium.org/developers/how-tos/build-instructions-ios to Markdown and check it in docs/ directory. The process for doing this was done partially by command line tools and partially manually after inspection at http://dillinger.io/. The command lines to generate the markdown file were: $ wget https://www.chromium.org/developers/how-tos/build-instructions-ios $ pandoc -s -r html build-instructions-ios -o ios_build_instructions.md BUG=None TEST=opened ios_build_instructions.md in dillinger.io and visually inspected it. R=sdefresne@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== docs: convert ios build instructions from html to markdown This patch converts iOS Build Instructions from https://www.chromium.org/developers/how-tos/build-instructions-ios to Markdown and check it in docs/ directory. The process for doing this was done partially by command line tools and partially manually after inspection at http://dillinger.io/. The command lines to generate the markdown file were: $ wget https://www.chromium.org/developers/how-tos/build-instructions-ios $ pandoc -s -r html build-instructions-ios -o ios_build_instructions.md BUG=None TEST=opened ios_build_instructions.md in dillinger.io and visually inspected it. R=sdefresne@chromium.org ========== to ========== docs: convert ios build instructions from html to markdown This patch converts iOS Build Instructions from https://www.chromium.org/developers/how-tos/build-instructions-ios to Markdown and check it in docs/ directory. The process for doing this was done partially by command line tools and partially manually after inspection at http://dillinger.io/. The command lines to generate the markdown file were: $ wget https://www.chromium.org/developers/how-tos/build-instructions-ios $ pandoc -s -r html build-instructions-ios -o ios_build_instructions.md BUG=None TEST=opened ios_build_instructions.md in dillinger.io and visually inspected it. R=sdefresne@chromium.org Committed: https://crrev.com/b8f70688d44d033c9f14786cb19ea6b176559456 Cr-Commit-Position: refs/heads/master@{#378417} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b8f70688d44d033c9f14786cb19ea6b176559456 Cr-Commit-Position: refs/heads/master@{#378417}
Message was sent while issue was closed.
Sorry for giving feedback after the CL landed (unfortunately codereview does not preview the markdown). https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... docs/ios_build_instructions.md:92: { Looking at the processed file at https://chromium.googlesource.com/chromium/src/+/master/docs/ios_build_instru..., I think we should do the following change: `{ "GYP\_DEFINES": "OS=ios chromium\_ios\_signing=0", "GYP\_GENERATORS": "ninja,xcode-ninja", }` https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... docs/ios_build_instructions.md:100: \ Remove. https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... docs/ios_build_instructions.md:106: \ Remove. https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... docs/ios_build_instructions.md:110: \ Remove.
Message was sent while issue was closed.
Addressed at https://codereview.chromium.org/1753693002. https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... File docs/ios_build_instructions.md (right): https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... docs/ios_build_instructions.md:92: { On 2016/03/01 08:47:00, sdefresne wrote: > Looking at the processed file at > https://chromium.googlesource.com/chromium/src/+/master/docs/ios_build_instru..., > I think we should do the following change: > > `{ > "GYP\_DEFINES": "OS=ios chromium\_ios\_signing=0", > "GYP\_GENERATORS": "ninja,xcode-ninja", > }` Done. https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... docs/ios_build_instructions.md:100: \ On 2016/03/01 08:47:00, sdefresne wrote: > Remove. Done. https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... docs/ios_build_instructions.md:106: \ On 2016/03/01 08:47:00, sdefresne wrote: > Remove. Done. https://codereview.chromium.org/1747873002/diff/40001/docs/ios_build_instruct... docs/ios_build_instructions.md:110: \ On 2016/03/01 08:47:00, sdefresne wrote: > Remove. Done. |
