Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 1753693002: docs: fix markdown issues in ios_build_instructions.md (Closed)

Created:
4 years, 9 months ago by tfarina
Modified:
4 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: fix markdown issues in ios_build_instructions.md This patch fixes some layout issues when rendering the Markdown file in Gitiles. This should address the post-commit review from https://chromium.googlesource.com/chromium/src/+/b8f70688d44d033c9f14786cb19ea6b176559456 BUG=None TEST=loaded the markdown file in a Markdown viewer(I used http://dillinger.io/), and visually inspected it. R=sdefresne@chromium.org Committed: https://crrev.com/e6cdc9c99a27d543acadc3216572616e588aa064 Cr-Commit-Position: refs/heads/master@{#378522}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M docs/ios_build_instructions.md View 1 chunk +2 lines, -11 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
tfarina
https://codereview.chromium.org/1753693002/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (left): https://codereview.chromium.org/1753693002/diff/1/docs/ios_build_instructions.md#oldcode106 docs/ios_build_instructions.md:106: \ Admittedly, I didn't know what to do (how ...
4 years, 9 months ago (2016-03-01 12:54:52 UTC) #1
tfarina
I forgot to note that it might be possible to verify this locally by running ...
4 years, 9 months ago (2016-03-01 13:04:54 UTC) #2
sdefresne
lgtm
4 years, 9 months ago (2016-03-01 19:04:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753693002/1
4 years, 9 months ago (2016-03-01 19:25:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 19:36:24 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 19:37:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6cdc9c99a27d543acadc3216572616e588aa064
Cr-Commit-Position: refs/heads/master@{#378522}

Powered by Google App Engine
This is Rietveld 408576698