Rename raw_image() to image_bytes() in UserImage

Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

Along the way, get rid of DiscardRawImage() that is not
used at all

BUG=590630
TEST=everything builds as before
TBR=achuith@chromium.org for components/user_manager, bshe@chromium.org for components/wallpaper

Committed: https://crrev.com/730760a001e019fc2f5fa8d8a2035d0e9dd8539d
Cr-Commit-Position: refs/heads/master@{#378687}

[satorux1, 2016-02-29 07:43:31]

satorux@chromium.org changed reviewers:
+ hashimoto@chromium.org

[hashimoto, 2016-02-29 08:01:59]

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/user.h
File components/user_manager/user.h (right):

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user.h:136: // Whether |web_image| contains data in
format that is considered safe to
Shouldn't |web_image| be replaced with |user_image_|?

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
File components/user_manager/user_image/user_image.h (right):

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user_image/user_image.h:18: // Wrapper class storing a
still image and it's web representation in a
s/it's/its/?

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user_image/user_image.h:25: typedef std::vector<unsigned
char> WebImage;
I'm not sure if WebImage is better than RawImage.
RawImage is "raw" because the skia image is created by reading it.
The new name "WebImage" tells nothing about the relationship between them.

Also, the name "WebImage" implies it provides methods to get information about
the image (e.g. size, color depth), while it's actually just a blob data.

[satorux1, 2016-02-29 08:11:41]

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/user.h
File components/user_manager/user.h (right):

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user.h:136: // Whether |web_image| contains data in
format that is considered safe to
On 2016/02/29 08:01:59, hashimoto wrote:
> Shouldn't |web_image| be replaced with |user_image_|?

Done.

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
File components/user_manager/user_image/user_image.h (right):

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user_image/user_image.h:18: // Wrapper class storing a
still image and it's web representation in a
On 2016/02/29 08:01:59, hashimoto wrote:
> s/it's/its/?

Done.

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user_image/user_image.h:25: typedef std::vector<unsigned
char> WebImage;
On 2016/02/29 08:01:59, hashimoto wrote:
> I'm not sure if WebImage is better than RawImage.
> RawImage is "raw" because the skia image is created by reading it.

It's not always the case. RawImage is generated from the skia image if UserImage
is created with CreateAndEncode().


> The new name "WebImage" tells nothing about the relationship between them.
> 
> Also, the name "WebImage" implies it provides methods to get information about
> the image (e.g. size, color depth), while it's actually just a blob data.

How about removing the typedef?

[hashimoto, 2016-02-29 10:03:19]

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
File components/user_manager/user_image/user_image.h (right):

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user_image/user_image.h:25: typedef std::vector<unsigned
char> WebImage;
On 2016/02/29 08:11:41, satorux1 wrote:
> On 2016/02/29 08:01:59, hashimoto wrote:
> > I'm not sure if WebImage is better than RawImage.
> > RawImage is "raw" because the skia image is created by reading it.
> 
> It's not always the case. RawImage is generated from the skia image if
UserImage
> is created with CreateAndEncode().
> 
> 
> > The new name "WebImage" tells nothing about the relationship between them.
> > 
> > Also, the name "WebImage" implies it provides methods to get information
about
> > the image (e.g. size, color depth), while it's actually just a blob data.
> 
> How about removing the typedef?

Removing typedef doesn't sound like a good thing to do.
How about something as boring as "EncodedBytes" or "CompressedImageData"?
"WebImage" sounds fancy, but it's not obvious what it actually means.

[satorux1, 2016-02-29 11:07:50]

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
File components/user_manager/user_image/user_image.h (right):

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user_image/user_image.h:25: typedef std::vector<unsigned
char> WebImage;
On 2016/02/29 10:03:19, hashimoto wrote:
> On 2016/02/29 08:11:41, satorux1 wrote:
> > On 2016/02/29 08:01:59, hashimoto wrote:
> > > I'm not sure if WebImage is better than RawImage.
> > > RawImage is "raw" because the skia image is created by reading it.
> > 
> > It's not always the case. RawImage is generated from the skia image if
> UserImage
> > is created with CreateAndEncode().
> > 
> > 
> > > The new name "WebImage" tells nothing about the relationship between them.
> > > 
> > > Also, the name "WebImage" implies it provides methods to get information
> about
> > > the image (e.g. size, color depth), while it's actually just a blob data.
> > 
> > How about removing the typedef?
> 
> Removing typedef doesn't sound like a good thing to do.
> How about something as boring as "EncodedBytes" or "CompressedImageData"?
> "WebImage" sounds fancy, but it's not obvious what it actually means.

How about just Bytes? This might sound too generic, but it's inside of a class
in a namespace, so the client code will look like user_manager::UserImage::Bytes

[hashimoto, 2016-03-01 05:59:10]

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
File components/user_manager/user_image/user_image.h (right):

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user_image/user_image.h:25: typedef std::vector<unsigned
char> WebImage;
On 2016/02/29 11:07:49, satorux1 wrote:
> On 2016/02/29 10:03:19, hashimoto wrote:
> > On 2016/02/29 08:11:41, satorux1 wrote:
> > > On 2016/02/29 08:01:59, hashimoto wrote:
> > > > I'm not sure if WebImage is better than RawImage.
> > > > RawImage is "raw" because the skia image is created by reading it.
> > > 
> > > It's not always the case. RawImage is generated from the skia image if
> > UserImage
> > > is created with CreateAndEncode().
> > > 
> > > 
> > > > The new name "WebImage" tells nothing about the relationship between
them.
> > > > 
> > > > Also, the name "WebImage" implies it provides methods to get information
> > about
> > > > the image (e.g. size, color depth), while it's actually just a blob
data.
> > > 
> > > How about removing the typedef?
> > 
> > Removing typedef doesn't sound like a good thing to do.
> > How about something as boring as "EncodedBytes" or "CompressedImageData"?
> > "WebImage" sounds fancy, but it's not obvious what it actually means.
> 
> How about just Bytes? This might sound too generic, but it's inside of a class
> in a namespace, so the client code will look like
user_manager::UserImage::Bytes

Bytes as a type name sounds sufficiently boring too me.
Please don't forget to give methods and variables boring but informative names
too.

[satorux1, 2016-03-01 07:33:10]

Description was changed from

==========
Rename raw_image() to web_image() in UserImage

raw_image() was a misnomer, because this function returns
an image encoded in web-compatible format such as JPEG for
displaying the user image in WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

BUG=590630
TEST=everything builds as before
==========

to

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

BUG=590630
TEST=everything builds as before
==========

[satorux1, 2016-03-01 07:37:04]

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
File components/user_manager/user_image/user_image.h (right):

https://codereview.chromium.org/1747843002/diff/1/components/user_manager/use...
components/user_manager/user_image/user_image.h:25: typedef std::vector<unsigned
char> WebImage;
On 2016/03/01 05:59:10, hashimoto wrote:
> On 2016/02/29 11:07:49, satorux1 wrote:
> > On 2016/02/29 10:03:19, hashimoto wrote:
> > > On 2016/02/29 08:11:41, satorux1 wrote:
> > > > On 2016/02/29 08:01:59, hashimoto wrote:
> > > > > I'm not sure if WebImage is better than RawImage.
> > > > > RawImage is "raw" because the skia image is created by reading it.
> > > > 
> > > > It's not always the case. RawImage is generated from the skia image if
> > > UserImage
> > > > is created with CreateAndEncode().
> > > > 
> > > > 
> > > > > The new name "WebImage" tells nothing about the relationship between
> them.
> > > > > 
> > > > > Also, the name "WebImage" implies it provides methods to get
information
> > > about
> > > > > the image (e.g. size, color depth), while it's actually just a blob
> data.
> > > > 
> > > > How about removing the typedef?
> > > 
> > > Removing typedef doesn't sound like a good thing to do.
> > > How about something as boring as "EncodedBytes" or "CompressedImageData"?
> > > "WebImage" sounds fancy, but it's not obvious what it actually means.
> > 
> > How about just Bytes? This might sound too generic, but it's inside of a
class
> > in a namespace, so the client code will look like
> user_manager::UserImage::Bytes
> 
> Bytes as a type name sounds sufficiently boring too me.
> Please don't forget to give methods and variables boring but informative names
> too.

Done!

[hashimoto, 2016-03-01 08:04:22]

lgtm with nits

https://codereview.chromium.org/1747843002/diff/60001/components/user_manager...
File components/user_manager/user_image/user_image.h (right):

https://codereview.chromium.org/1747843002/diff/60001/components/user_manager...
components/user_manager/user_image/user_image.h:53: void DiscardBytes();
Is this needed?

https://codereview.chromium.org/1747843002/diff/60001/components/wallpaper/wa...
File components/wallpaper/wallpaper_manager_base.h (right):

https://codereview.chromium.org/1747843002/diff/60001/components/wallpaper/wa...
components/wallpaper/wallpaper_manager_base.h:387: const
user_manager::UserImage::Bytes& web_image,
image_bytes

[satorux1, 2016-03-01 08:11:09]

https://codereview.chromium.org/1747843002/diff/60001/components/user_manager...
File components/user_manager/user_image/user_image.h (right):

https://codereview.chromium.org/1747843002/diff/60001/components/user_manager...
components/user_manager/user_image/user_image.h:53: void DiscardBytes();
On 2016/03/01 08:04:22, hashimoto wrote:
> Is this needed?

good catch. not used at all. removed!

https://codereview.chromium.org/1747843002/diff/60001/components/wallpaper/wa...
File components/wallpaper/wallpaper_manager_base.h (right):

https://codereview.chromium.org/1747843002/diff/60001/components/wallpaper/wa...
components/wallpaper/wallpaper_manager_base.h:387: const
user_manager::UserImage::Bytes& web_image,
On 2016/03/01 08:04:22, hashimoto wrote:
> image_bytes

Done.

[satorux1, 2016-03-01 08:11:44]

Description was changed from

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

BUG=590630
TEST=everything builds as before
==========

to

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

Along the way, get rid of DiscardRawImage() that is not
used at all

BUG=590630
TEST=everything builds as before
==========

[satorux1, 2016-03-02 00:12:42]

The CQ bit was checked by satorux@chromium.org

[satorux1, 2016-03-02 00:12:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
hashimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1747843002/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2016-03-02 00:13:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1747843002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1747843002/80001

[commit-bot: I haz the power, 2016-03-02 00:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 00:29:00]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[satorux1, 2016-03-02 03:36:18]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2016-03-02 03:36:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1747843002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1747843002/80001

[commit-bot: I haz the power, 2016-03-02 03:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-02 03:50:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[satorux1, 2016-03-02 04:12:54]

Description was changed from

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

Along the way, get rid of DiscardRawImage() that is not
used at all

BUG=590630
TEST=everything builds as before
==========

to

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

Along the way, get rid of DiscardRawImage() that is not
used at all

BUG=590630
TEST=everything builds as before
TBR=achuith@chromium.org for components/user_manager, bshe@chromium.org for
components/wallpaper
==========

[satorux1, 2016-03-02 04:13:08]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2016-03-02 04:13:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1747843002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1747843002/80001

[commit-bot: I haz the power, 2016-03-02 04:22:39]

Description was changed from

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

Along the way, get rid of DiscardRawImage() that is not
used at all

BUG=590630
TEST=everything builds as before
TBR=achuith@chromium.org for components/user_manager, bshe@chromium.org for
components/wallpaper
==========

to

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

Along the way, get rid of DiscardRawImage() that is not
used at all

BUG=590630
TEST=everything builds as before
TBR=achuith@chromium.org for components/user_manager, bshe@chromium.org for
components/wallpaper
==========

[commit-bot: I haz the power, 2016-03-02 04:22:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-02 04:23:49]

Description was changed from

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

Along the way, get rid of DiscardRawImage() that is not
used at all

BUG=590630
TEST=everything builds as before
TBR=achuith@chromium.org for components/user_manager, bshe@chromium.org for
components/wallpaper
==========

to

==========
Rename raw_image() to image_bytes() in UserImage

raw_image() was a misnomer, because this function returns
data bytes representation of an image encoded in web-compatible
format such as JPEG for WebUI (ex. chrome://userimage/),
rather than raw bitmap data.

Along the way, get rid of DiscardRawImage() that is not
used at all

BUG=590630
TEST=everything builds as before
TBR=achuith@chromium.org for components/user_manager, bshe@chromium.org for
components/wallpaper

Committed: https://crrev.com/730760a001e019fc2f5fa8d8a2035d0e9dd8539d
Cr-Commit-Position: refs/heads/master@{#378687}
==========

[commit-bot: I haz the power, 2016-03-02 04:23:51]

Patchset 5 (id:??) landed as
https://crrev.com/730760a001e019fc2f5fa8d8a2035d0e9dd8539d
Cr-Commit-Position: refs/heads/master@{#378687}